Make sure first Gradle Sync is downloading 3rd party deps #39426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49231058 |
Base commit: b29b393 |
…9426) Summary: When opening the react-native repo in Android Studio the first time, users is missing 3rd party native dependencies, which gets downloaded during the first build. Here I'm hooking the Gradle sync step to the `preBuild` task that takes care of preparing the repo so that the whole build can succeeds (i.e. downloading and unzipping native deps, running codegen, preparing hermes/hermesc, etc.). Changelog: [Internal] [Changed] - Make sure first Gradle Sync is downloading 3rd party deps Reviewed By: cipolleschi Differential Revision: D49231058
cortinico
force-pushed
the
export-D49231058
branch
from
d7d1062 to
46b4010
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49231058 |
|
This pull request has been merged in f2884a7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When opening the react-native repo in Android Studio the first time, users is missing 3rd party native dependencies,
which gets downloaded during the first build.
Here I'm hooking the Gradle sync step to the
preBuildtask that takes care of preparing the repo so that the whole build can succeeds (i.e. downloading and unzipping native deps, running codegen, preparing hermes/hermesc, etc.).Changelog:
[Internal] [Changed] - Make sure first Gradle Sync is downloading 3rd party deps
Differential Revision: D49231058