Prevent Babel registration from transforming plugins with arbitrary config #39429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49238671 |
robhogan
added a commit
to robhogan/react-native
that referenced
this pull request
Sep 13, 2023
…onfig (facebook#39429) Summary: X-link: facebook/metro#1082 Using `require` after `const registerFn = require('babel/register')` but before `registerFn(config)` causes Babel to transform required code with the default configuration (ie, using a nearby `babel.config.js`, if available). This was causing the Babel plugins loaded by `metro-babel-register` to be (unnecessarily) transformed according to `babel.config.js`, which actually fails if the plugins/presets referenced in `babel.config.js` themselves require transformation. This ensures no code is loaded in between registering Babel as a side effect of requiring Babel register, and replacing that hook with something explicitly configured. ## React Native Changelog: [Internal] ## Metro ``` * **[Fix]:** `metro-babel-register` prevent arbitrary transformation of Babel plugins during registration setup ``` Differential Revision: D49238671
robhogan
force-pushed
the
export-D49238671
branch
from
a63a92f to
9375d35
Compare
robhogan
added a commit
to robhogan/metro
that referenced
this pull request
Sep 13, 2023
…onfig (facebook#1082) Summary: X-link: facebook/react-native#39429 Using `require` after `const registerFn = require('babel/register')` but before `registerFn(config)` causes Babel to transform required code with the default configuration (ie, using a nearby `babel.config.js`, if available). This was causing the Babel plugins loaded by `metro-babel-register` to be (unnecessarily) transformed according to `babel.config.js`, which actually fails if the plugins/presets referenced in `babel.config.js` themselves require transformation. This ensures no code is loaded in between registering Babel as a side effect of requiring Babel register, and replacing that hook with something explicitly configured. ## React Native Changelog: [Internal] ## Metro ``` * **[Fix]:** `metro-babel-register` prevent arbitrary transformation of Babel plugins during registration setup ``` Differential Revision: D49238671
|
This pull request was exported from Phabricator. Differential Revision: D49238671 |
…onfig
Summary:
Using `require` after `const registerFn = require('babel/register')` but before `registerFn(config)` causes Babel to transform required code with the default configuration (ie, using a nearby `babel.config.js`, if available).
This was causing the Babel plugins loaded by `metro-babel-register` to be (unnecessarily) transformed according to `babel.config.js`, which actually fails if the plugins/presets referenced in `babel.config.js` themselves require transformation.
This ensures no code is loaded in between registering Babel as a side effect of requiring Babel register, and replacing that hook with something explicitly configured.
## React Native
Changelog: [Internal]
## Metro
```
* **[Fix]:** `metro-babel-register` prevent arbitrary transformation of Babel plugins during registration setup
```
Reviewed By: dmytrorykun
Differential Revision: D49238671
robhogan
force-pushed
the
export-D49238671
branch
from
9375d35 to
a86bbd5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49238671 |
facebook-github-bot
pushed a commit
to facebook/metro
that referenced
this pull request
Sep 14, 2023
…onfig Summary: X-link: facebook/react-native#39429 Using `require` after `const registerFn = require('babel/register')` but before `registerFn(config)` causes Babel to transform required code with the default configuration (ie, using a nearby `babel.config.js`, if available). This was causing the Babel plugins loaded by `metro-babel-register` to be (unnecessarily) transformed according to `babel.config.js`, which actually fails if the plugins/presets referenced in `babel.config.js` themselves require transformation. This ensures no code is loaded in between registering Babel as a side effect of requiring Babel register, and replacing that hook with something explicitly configured. ## React Native Changelog: [Internal] ## Metro ``` * **[Fix]:** `metro-babel-register` prevent arbitrary transformation of Babel plugins during registration setup ``` Reviewed By: dmytrorykun Differential Revision: D49238671 fbshipit-source-id: 52a55b1b5dbd127171558c056f16ab04e8fa8232
|
This pull request has been merged in cda1cf9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/metro#1082
Using
requireafterconst registerFn = require('babel/register')but beforeregisterFn(config)causes Babel to transform required code with the default configuration (ie, using a nearbybabel.config.js, if available).This was causing the Babel plugins loaded by
metro-babel-registerto be (unnecessarily) transformed according tobabel.config.js, which actually fails if the plugins/presets referenced inbabel.config.jsthemselves require transformation.This ensures no code is loaded in between registering Babel as a side effect of requiring Babel register, and replacing that hook with something explicitly configured.
React Native
Changelog: [Internal]
Metro
Differential Revision: D49238671