Fix Codegen build script on EdenFS #39566
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49468891 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Sep 20, 2023
Summary: Fixes running the `build.sh` script for `react-native-codegen` when on [EdenFS](https://github.com/facebook/sapling). This would previously fail due a filesystem "unable to copy extended attributes" error. This only affects development within the React Native monorepo. Practically, this equates to a workflow improvement for Meta engineers when creating `RNTester` builds. NOTE: The change from `mv` to `cp -R` makes this script more expensive, which will make Android builds via Gradle take slightly longer. I have a WIP cleanup planned which will 1/ move `react-native-codegen` to the [shared monorepo build setup](facebook#38718), and 2/ drop this step entirely from the Android Gradle build. Changelog: [Internal] Differential Revision: D49468891
huntie
force-pushed
the
export-D49468891
branch
from
a8969a3
to
4b3e626
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49468891 |
Base commit: ea85b31 |
huntie
force-pushed
the
export-D49468891
branch
from
4b3e626
to
e052257
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Sep 21, 2023
Summary: Fixes running the `build.sh` script for `react-native-codegen` when on [EdenFS](https://github.com/facebook/sapling). This would previously fail due a filesystem "unable to copy extended attributes" error. This only affects development within the React Native monorepo. Practically, this equates to a workflow improvement for Meta engineers when creating `RNTester` builds. NOTE: **This is temporary**. The change from `mv` to `cp -R` makes this script more expensive, which will make Android builds via Gradle take slightly longer. I have a WIP cleanup planned which will 1/ move `react-native-codegen` to the [shared monorepo build setup](facebook#38718), and 2/ drop this step entirely from the Android Gradle build. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D49468891
|
This pull request was exported from Phabricator. Differential Revision: D49468891 |
Summary: Fixes running the `build.sh` script for `react-native-codegen` when on [EdenFS](https://github.com/facebook/sapling). This would previously fail due a filesystem "unable to copy extended attributes" error. This only affects development within the React Native monorepo. Practically, this equates to a workflow improvement for Meta engineers when creating `RNTester` builds. NOTE: **This is temporary**. The change from `mv` to `cp -R` makes this script more expensive, which will make Android builds via Gradle take slightly longer. I have a WIP cleanup planned which will 1/ move `react-native-codegen` to the [shared monorepo build setup](facebook#38718), and 2/ drop this step entirely from the Android Gradle build. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D49468891
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Sep 21, 2023
Summary: Fixes running the `build.sh` script for `react-native-codegen` when on [EdenFS](https://github.com/facebook/sapling). This would previously fail due a filesystem "unable to copy extended attributes" error. This only affects development within the React Native monorepo. Practically, this equates to a workflow improvement for Meta engineers when creating `RNTester` builds. NOTE: **This is temporary**. The change from `mv` to `cp -R` makes this script more expensive, which will make Android builds via Gradle take slightly longer. I have a WIP cleanup planned which will 1/ move `react-native-codegen` to the [shared monorepo build setup](facebook#38718), and 2/ drop this step entirely from the Android Gradle build. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D49468891
huntie
force-pushed
the
export-D49468891
branch
from
e052257
to
ecb41e9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49468891 |
huntie
force-pushed
the
export-D49468891
branch
from
ecb41e9
to
bcb5077
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49468891 |
|
This pull request has been merged in eaec4f7. |
ShevO27
pushed a commit
to ShevO27/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39566 Fixes running the `build.sh` script for `react-native-codegen` when on [EdenFS](https://github.com/facebook/sapling). This would previously fail due a filesystem "unable to copy extended attributes" error. This only affects development within the React Native monorepo. Practically, this equates to a workflow improvement for Meta engineers when creating `RNTester` builds. NOTE: **This is temporary**. The change from `mv` to `cp -R` makes this script more expensive, which will make Android builds via Gradle take slightly longer. I have a WIP cleanup planned which will 1/ move `react-native-codegen` to the [shared monorepo build setup](facebook#38718), and 2/ drop this step entirely from the Android Gradle build. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D49468891 fbshipit-source-id: 25d5db81798cf8ab150a135174a45f4d4c2cb5a2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes running the
build.shscript forreact-native-codegenwhen on EdenFS. This would previously fail due a filesystem "unable to copy extended attributes" error.This only affects development within the React Native monorepo. Practically, this equates to a workflow improvement for Meta engineers when creating
RNTesterbuilds.Note
This is temporary. The change from
mvtocp -Rmakes this script more expensive, which will make Android builds via Gradle take slightly longer. I have a WIP cleanup planned which will 1/ movereact-native-codegento the shared monorepo build setup, and 2/ drop this step entirely from the Android Gradle build.Changelog: [Internal]
Differential Revision: D49468891