Fix handling of negative flex gap #39596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49530494 |
Base commit: df492cc |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 26, 2023
Summary: X-link: facebook/react-native#39596 Pull Request resolved: facebook#1405 I noticed that we weren't clamping negative flex gap values to zero. This fixes that bug. Reviewed By: rshest Differential Revision: D49530494 fbshipit-source-id: 81ac659482689911f6fc3b11b671af6950d0bd43
|
This pull request was exported from Phabricator. Differential Revision: D49530494 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39596 X-link: facebook/yoga#1405 I noticed that we weren't clamping negative flex gap values to zero. This fixes that bug. Reviewed By: rshest Differential Revision: D49530494 fbshipit-source-id: 52fd822d642b9470b9ec24784a85d41915a7f265
NickGerleman
force-pushed
the
export-D49530494
branch
from
cd6acf2 to
8dfe6e3
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 26, 2023
Summary: X-link: facebook/react-native#39596 Pull Request resolved: facebook#1405 I noticed that we weren't clamping negative flex gap values to zero. This fixes that bug. Reviewed By: rshest Differential Revision: D49530494 fbshipit-source-id: aa87547419e92d733487360db4c8937f9a9e757f
|
This pull request was exported from Phabricator. Differential Revision: D49530494 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39596 X-link: facebook/yoga#1405 I noticed that we weren't clamping negative flex gap values to zero. This fixes that bug. Reviewed By: rshest Differential Revision: D49530494 fbshipit-source-id: 94592944ef35017b2468395fa3ad1817ef0d9841
NickGerleman
force-pushed
the
export-D49530494
branch
from
8dfe6e3 to
f601b5c
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 28, 2023
Summary: X-link: facebook/react-native#39596 Pull Request resolved: facebook#1405 I noticed that we weren't clamping negative flex gap values to zero. This fixes that bug. Reviewed By: rshest Differential Revision: D49530494 fbshipit-source-id: ac9e1e83e9c98bd7e20e1e861852b68e4b6117e7
|
This pull request was exported from Phabricator. Differential Revision: D49530494 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 28, 2023
Summary: Pull Request resolved: facebook#39596 X-link: facebook/yoga#1405 I noticed that we weren't clamping negative flex gap values to zero. This fixes that bug. Reviewed By: rshest Differential Revision: D49530494 fbshipit-source-id: 7ac7fd163a61616ae7897ca7da3e52f920120e8d
NickGerleman
force-pushed
the
export-D49530494
branch
2 times, most recently
from
10155c6 to
1c9038d
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 1, 2023
Summary: X-link: facebook/yoga#1405 I noticed that we weren't clamping negative flex gap values to zero. This fixes that bug. Reviewed By: rshest Differential Revision: D49530494
|
This pull request was exported from Phabricator. Differential Revision: D49530494 |
Summary: X-link: facebook/yoga#1405 I noticed that we weren't clamping negative flex gap values to zero. This fixes that bug. Reviewed By: rshest Differential Revision: D49530494
NickGerleman
force-pushed
the
export-D49530494
branch
from
1c9038d to
ead7c3c
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Oct 1, 2023
Summary: X-link: facebook/react-native#39596 I noticed that we weren't clamping negative flex gap values to zero. This fixes that bug. Reviewed By: rshest Differential Revision: D49530494
|
This pull request was exported from Phabricator. Differential Revision: D49530494 |
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Oct 1, 2023
Summary: X-link: facebook/react-native#39596 Pull Request resolved: #1405 I noticed that we weren't clamping negative flex gap values to zero. This fixes that bug. Reviewed By: rshest Differential Revision: D49530494 fbshipit-source-id: 069db7312f72a085c5c4b01ead7bc66a353a07e5
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Oct 1, 2023
Summary: X-link: facebook/react-native#39596 X-link: facebook/yoga#1405 I noticed that we weren't clamping negative flex gap values to zero. This fixes that bug. Reviewed By: rshest Differential Revision: D49530494 fbshipit-source-id: 069db7312f72a085c5c4b01ead7bc66a353a07e5
|
This pull request has been merged in aa65e92. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: I noticed that we weren't clamping negative flex gap values to zero. This fixes that bug.
Differential Revision: D49530494