C++ style enums 16/N: Dimension #39598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
Base commit: e21b3c8 |
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39598 X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: c0f643b2a590ee09264def51da24af224d1bff17
NickGerleman
force-pushed
the
export-D49475409
branch
from
e92da63 to
0e990e7
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 26, 2023
Summary: X-link: facebook/react-native#39598 Pull Request resolved: facebook#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: 56688d703cf1149740e3b689d32c8fd24d2b2413
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 26, 2023
Summary: X-link: facebook/react-native#39598 Pull Request resolved: facebook#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: 6c71d79381c1987c1b504dc1de314116788b1d35
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39598 X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: f268ce2c3e90986559ef3e49d00a5fb122c2ce18
NickGerleman
force-pushed
the
export-D49475409
branch
from
0e990e7 to
1908b79
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 28, 2023
Summary: X-link: facebook/react-native#39598 Pull Request resolved: facebook#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: bc8ba256bfcd1e89b0fa1562e282cbc4dab4a7ee
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 28, 2023
Summary: Pull Request resolved: facebook#39598 X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: 6545a948a90f0d63a00fac20a515d03df8694a1b
NickGerleman
force-pushed
the
export-D49475409
branch
from
1908b79 to
b640297
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 28, 2023
Summary: X-link: facebook/react-native#39598 Pull Request resolved: facebook#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: 53c25f2e0f58db633e1a78095dc7b8561e9b7921
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 28, 2023
Summary: Pull Request resolved: facebook#39598 X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: 6aee39d7c23e2a2a23fdced36d1ec5924576e457
NickGerleman
force-pushed
the
export-D49475409
branch
from
b640297 to
ea3b66b
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 28, 2023
Summary: X-link: facebook/react-native#39598 Pull Request resolved: facebook#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: c63c4662e63bd7f81369596215ab7b15a0afd051
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 28, 2023
Summary: Pull Request resolved: facebook#39598 X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: 505d93803baf7680c9f606cc5f7fcff7f0b2c118
NickGerleman
force-pushed
the
export-D49475409
branch
from
ea3b66b to
8a15fcf
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
force-pushed
the
export-D49475409
branch
from
8a15fcf to
8278995
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/react-native#39598 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
force-pushed
the
export-D49475409
branch
from
bcd95c1 to
d7201be
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
force-pushed
the
export-D49475409
branch
from
d7201be to
de4532d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
force-pushed
the
export-D49475409
branch
from
de4532d to
7b0306b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
force-pushed
the
export-D49475409
branch
from
7b0306b to
bcc8738
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
force-pushed
the
export-D49475409
branch
from
bcc8738 to
90684b4
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
force-pushed
the
export-D49475409
branch
from
90684b4 to
fdbc71e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
NickGerleman
force-pushed
the
export-D49475409
branch
from
fdbc71e to
bc949b0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
Summary: X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409
|
This pull request was exported from Phabricator. Differential Revision: D49475409 |
NickGerleman
force-pushed
the
export-D49475409
branch
from
bc949b0 to
f671450
Compare
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/react-native#39598 Pull Request resolved: #1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: 7d4c31e8a84485baea0dab50b5cf16b86769fa07
|
This pull request was successfully merged by @NickGerleman in 5be6f49. When will my fix make it into a release? | Upcoming Releases |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 29, 2023
Summary: X-link: facebook/react-native#39598 X-link: facebook/yoga#1403 Replaces all usages of YGDimension with Dimension. Adds `yoga::to_underlying` to act like `std::to_underlying`, added in C++ 23. This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49475409 fbshipit-source-id: 7d4c31e8a84485baea0dab50b5cf16b86769fa07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Replaces all usages of YGDimension with Dimension.
Adds
yoga::to_underlyingto act likestd::to_underlying, added in C++ 23.This enum is oddly only used internally, and is never an input to the public API, but it handled as any other public generated enum. Potentially some more cleanup to do there.
Differential Revision: D49475409