Rename onCatalystInstanceDestroy -> invalidate #39611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49469208 |
|
This pull request was exported from Phabricator. Differential Revision: D49469208 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 22, 2023
Summary: Pull Request resolved: facebook#39611 I'm renaming onCatalystInstanceDestroy -> invalidate, this is necessary to converge TurboModuleRegistry -> turboModuleManager in the next diffs of the stack changelog: [intenral] internal Reviewed By: arushikesarwani94 Differential Revision: D49469208 fbshipit-source-id: db1421e6ddaa99cfde062bb41b4307990749b060
mdvacca
force-pushed
the
export-D49469208
branch
from
c687b0a to
58f8d84
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49469208 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 22, 2023
Summary: Pull Request resolved: facebook#39611 I'm renaming onCatalystInstanceDestroy -> invalidate, this is necessary to converge TurboModuleRegistry -> turboModuleManager in the next diffs of the stack changelog: [intenral] internal Reviewed By: arushikesarwani94 Differential Revision: D49469208 fbshipit-source-id: 25432a39566daf28323d800c58d0824786c2d6fb
mdvacca
force-pushed
the
export-D49469208
branch
from
58f8d84 to
fc35a65
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49469208 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 22, 2023
Summary: Pull Request resolved: facebook#39611 I'm renaming onCatalystInstanceDestroy -> invalidate, this is necessary to converge TurboModuleRegistry -> turboModuleManager in the next diffs of the stack changelog: [intenral] internal Reviewed By: arushikesarwani94 Differential Revision: D49469208 fbshipit-source-id: 97e0211d0527d003b9012f9438d7f1979d29b11d
mdvacca
force-pushed
the
export-D49469208
branch
from
fc35a65 to
62041e2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49469208 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 22, 2023
Summary: Pull Request resolved: facebook#39611 I'm renaming onCatalystInstanceDestroy -> invalidate, this is necessary to converge TurboModuleRegistry -> turboModuleManager in the next diffs of the stack changelog: [intenral] internal Reviewed By: arushikesarwani94 Differential Revision: D49469208 fbshipit-source-id: 2068a7a0338ee8519a2eaddc06dea57a93705fe8
mdvacca
force-pushed
the
export-D49469208
branch
from
62041e2 to
3afd080
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49469208 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 22, 2023
Summary: Pull Request resolved: facebook#39611 I'm renaming onCatalystInstanceDestroy -> invalidate, this is necessary to converge TurboModuleRegistry -> turboModuleManager in the next diffs of the stack changelog: [intenral] internal Reviewed By: arushikesarwani94 Differential Revision: D49469208 fbshipit-source-id: bfed262cb77e0f98489ce27f438ef84cfd0b0445
mdvacca
force-pushed
the
export-D49469208
branch
from
3afd080 to
6f739c1
Compare
Base commit: 36057da |
|
This pull request was exported from Phabricator. Differential Revision: D49469208 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 23, 2023
Summary: Pull Request resolved: facebook#39611 I'm renaming onCatalystInstanceDestroy -> invalidate, this is necessary to converge TurboModuleRegistry -> turboModuleManager in the next diffs of the stack changelog: [intenral] internal Reviewed By: arushikesarwani94 Differential Revision: D49469208 fbshipit-source-id: 9ffb794e1a624e7196b3b047fa268c3a155c3fea
mdvacca
force-pushed
the
export-D49469208
branch
from
6f739c1 to
1701a9a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49469208 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 23, 2023
Summary: Pull Request resolved: facebook#39611 I'm renaming onCatalystInstanceDestroy -> invalidate, this is necessary to converge TurboModuleRegistry -> turboModuleManager in the next diffs of the stack changelog: [intenral] internal Reviewed By: arushikesarwani94 Differential Revision: D49469208 fbshipit-source-id: de8d64cab3c1a2c791a4d5c8daf92dda67e714c0
mdvacca
force-pushed
the
export-D49469208
branch
from
1701a9a to
393c4af
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49469208 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 23, 2023
Summary: Pull Request resolved: facebook#39611 I'm renaming onCatalystInstanceDestroy -> invalidate, this is necessary to converge TurboModuleRegistry -> turboModuleManager in the next diffs of the stack changelog: [intenral] internal Reviewed By: arushikesarwani94 Differential Revision: D49469208 fbshipit-source-id: 44d881810ab99b8e5b64e1b92fb1670b533a7d88
mdvacca
force-pushed
the
export-D49469208
branch
from
393c4af to
6c2709b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49469208 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 24, 2023
Summary: Pull Request resolved: facebook#39611 I'm renaming onCatalystInstanceDestroy -> invalidate, this is necessary to converge TurboModuleRegistry -> turboModuleManager in the next diffs of the stack changelog: [intenral] internal Reviewed By: arushikesarwani94 Differential Revision: D49469208 fbshipit-source-id: dc692ef2e19a8b51939f49782fc7b5485f673f37
mdvacca
force-pushed
the
export-D49469208
branch
from
6c2709b to
893f1bf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49469208 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39611 I'm renaming onCatalystInstanceDestroy -> invalidate, this is necessary to converge TurboModuleRegistry -> turboModuleManager in the next diffs of the stack changelog: [intenral] internal Reviewed By: arushikesarwani94 Differential Revision: D49469208 fbshipit-source-id: fb1ce2358bf3c3752cf54ddcf0d3348b2823f498
mdvacca
force-pushed
the
export-D49469208
branch
from
893f1bf to
550ba40
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49469208 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39611 I'm renaming onCatalystInstanceDestroy -> invalidate, this is necessary to converge TurboModuleRegistry -> turboModuleManager in the next diffs of the stack changelog: [intenral] internal Reviewed By: arushikesarwani94 Differential Revision: D49469208 fbshipit-source-id: 273f8785bc94066db6450005f5d976f248cffb5d
mdvacca
force-pushed
the
export-D49469208
branch
from
550ba40 to
ab0c063
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49469208 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39611 I'm renaming onCatalystInstanceDestroy -> invalidate, this is necessary to converge TurboModuleRegistry -> turboModuleManager in the next diffs of the stack changelog: [intenral] internal Reviewed By: arushikesarwani94 Differential Revision: D49469208 fbshipit-source-id: 4b4161871695213b0e5b1c60cdb02667c0064b52
mdvacca
force-pushed
the
export-D49469208
branch
from
ab0c063 to
5448644
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49469208 |
Summary: Pull Request resolved: facebook#39611 I'm renaming onCatalystInstanceDestroy -> invalidate, this is necessary to converge TurboModuleRegistry -> turboModuleManager in the next diffs of the stack changelog: [intenral] internal Reviewed By: arushikesarwani94 Differential Revision: D49469208 fbshipit-source-id: 801c002f1daa4a929960f13804e0b5a629cb3f6d
mdvacca
force-pushed
the
export-D49469208
branch
from
5448644 to
3684938
Compare
|
This pull request has been merged in 5f215cd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I'm renaming onCatalystInstanceDestroy -> invalidate, this is necessary to converge TurboModuleRegistry -> turboModuleManager in the next diffs of the stack
changelog: [intenral] internal
Reviewed By: arushikesarwani94
Differential Revision: D49469208