Reduce visibility of JSCJavaScriptExecutorFactory #39737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49752141 |
|
This pull request was exported from Phabricator. Differential Revision: D49752141 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 1, 2023
Summary: Pull Request resolved: facebook#39737 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSCJavaScriptExecutorFactory Reviewed By: RSNara Differential Revision: D49752141 fbshipit-source-id: 2dbf2537d9f53a5aa89ab829a6d5fbe7a4cb6351
mdvacca
force-pushed
the
export-D49752141
branch
from
c2d9950 to
67802fa
Compare
Base commit: 294c0fa |
|
This pull request was exported from Phabricator. Differential Revision: D49752141 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 1, 2023
Summary: Pull Request resolved: facebook#39737 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSCJavaScriptExecutorFactory Reviewed By: RSNara Differential Revision: D49752141 fbshipit-source-id: 0431b871f2243e161c00390e26ad7d289d7b680c
mdvacca
force-pushed
the
export-D49752141
branch
from
67802fa to
12861ae
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49752141 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 1, 2023
Summary: Pull Request resolved: facebook#39737 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSCJavaScriptExecutorFactory Reviewed By: RSNara Differential Revision: D49752141 fbshipit-source-id: 3f8a7a34cc1779aacb86a551e675876130173e70
mdvacca
force-pushed
the
export-D49752141
branch
from
12861ae to
8290d1b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49752141 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 1, 2023
Summary: Pull Request resolved: facebook#39737 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSCJavaScriptExecutorFactory Reviewed By: RSNara Differential Revision: D49752141 fbshipit-source-id: ed240fe590953414a64b4b4c4f3d5aedf4ecd0d9
mdvacca
force-pushed
the
export-D49752141
branch
from
8290d1b to
ff6a009
Compare
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of DynamicFromArray Differential Revision: D49752134 fbshipit-source-id: 42f72505d6163d0000b34151c1490ee7b980d343
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of DynamicFromMap Differential Revision: D49752137 fbshipit-source-id: e3b7e346cc1745f9f1eca4b243c1b8c3ee48df88
|
This pull request was exported from Phabricator. Differential Revision: D49752141 |
Summary: Pull Request resolved: facebook#39737 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSCJavaScriptExecutorFactory Reviewed By: RSNara Differential Revision: D49752141 fbshipit-source-id: 2982990eb2321b119213f6f7152785f24f222ab7
mdvacca
force-pushed
the
export-D49752141
branch
from
ff6a009 to
505c3c2
Compare
|
This pull request has been merged in 11d51fe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
changelog: [Android][Changed] Reducing visibility of JSCJavaScriptExecutorFactory
Reviewed By: RSNara
Differential Revision: D49752141