Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Remove <Webkit/Webkit.h> import in RCTConvert.h #39794

Closed
wants to merge 1 commit into from

Conversation

Saadnajmi
Copy link
Contributor

Summary:

This PR is in response to #39758 (comment) .

RCTConvert.h currently takes an import of <Webkit/Webkit.h> for... one enum: WKDataDetectorTypes. This has a few problems:

  1. RCTConvert is JS engine agnostic, it shouldn't be depending on Webkit
  2. As far as I can tell, this code is dead, we also define (and use) the UIKit equivalent UIDataDetectorTypes.

Let's just combine the two, update some JS typing, and get rid of the Webkit header import.

Changelog:

[IOS] [CHANGED] - Remove <Webkit/Webkit.h> import in RCTConvert.h

Test Plan:

CI should pass

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Oct 4, 2023
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Oct 4, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,901,404 -21
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,380,171 -4,094
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: c4110d0
Branch: main

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against e270813

@facebook-github-bot
Copy link
Contributor

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 4, 2023
@facebook-github-bot
Copy link
Contributor

@NickGerleman merged this pull request in 452bf0f.

@Saadnajmi Saadnajmi deleted the webkit branch July 26, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants