Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typings for dismissActionSheet method #40012

Closed
wants to merge 3 commits into from
Closed

Add typings for dismissActionSheet method #40012

wants to merge 3 commits into from

Conversation

LRNZ09
Copy link
Contributor

@LRNZ09 LRNZ09 commented Oct 7, 2023 •
edited
Loading

Summary:

This pull request addresses two key issues. Firstly, it adds a missing docstring to the dismissActionSheet function within the ActionSheetIOS object. Secondly, it introduces TypeScript typings for the dismissActionSheet function.

Changelog:

[iOS] [Added] - Add missing docstring to the dismissActionSheet function in ActionSheetIOS.
[iOS] [Added] - Add TypeScript typings for the dismissActionSheet function in ActionSheetIOS.

Test Plan:

To ensure the code is solid, I followed these steps:

  1. Ran Flow to verify that there were no errors.
  2. Added a TypeScript test related to the dismissActionSheet function to ensure it's typed as expected.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 7, 2023
@github-actions
Copy link

github-actions bot commented Oct 7, 2023 •
edited
Loading

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 0d6bc83

@facebook-github-bot
Copy link
Contributor

@arushikesarwani94 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 10, 2023
@facebook-github-bot
Copy link
Contributor

@arushikesarwani94 merged this pull request in 89c7be8.

@LRNZ09 LRNZ09 deleted the feat/dismiss-action-sheet-typings branch October 10, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LRNZ09 @facebook-github-bot