Support grouped focus for switch #40739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50068169 |
|
This pull request was exported from Phabricator. Differential Revision: D50068169 |
carmenvkrol
added a commit
to carmenvkrol/react-native
that referenced
this pull request
Oct 9, 2023
Summary: Adding support for grouped accessibility focus on switch. This is when the switch itself shouldn't be directly focusable. Instead, the parent element should be focusable, including announcing the switch role and state changes, e.g. "on" and "off". Fix this issue in a couple ways: 1. Make sure to set the proper role for switch in FbReactSwitchCompat.java. 2. Set the state description in SwitchCompat.java so that uses the correct announcement of "off" and "on" instead of "checked" and "unchecked". Reviewed By: blavalla Differential Revision: D50068169
carmenvkrol
force-pushed
the
export-D50068169
branch
from
04e62b2 to
a5337a5
Compare
Summary: Adding support for grouped accessibility focus on switch. This is when the switch itself shouldn't be directly focusable. Instead, the parent element should be focusable, including announcing the switch role and state changes, e.g. "on" and "off". Fix this issue in a couple ways: 1. Make sure to set the proper role for switch in FbReactSwitchCompat.java. 2. Set the state description in SwitchCompat.java so that uses the correct announcement of "off" and "on" instead of "checked" and "unchecked". Reviewed By: blavalla Differential Revision: D50068169
|
This pull request was exported from Phabricator. Differential Revision: D50068169 |
carmenvkrol
force-pushed
the
export-D50068169
branch
from
a5337a5 to
f0cf2a1
Compare
Base commit: 29dce4d |
|
This pull request has been merged in 06c295c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adding support for grouped accessibility focus on switch. This is when the switch itself shouldn't be directly focusable. Instead, the parent element should be focusable, including announcing the switch role and state changes, e.g. "on" and "off".
Fix this issue in a couple ways:
Reviewed By: blavalla
Differential Revision: D50068169