Support NativeState in JSC #40746
Closed
Support NativeState in JSC #40746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49229022 |
javache
added a commit
to javache/hermes
that referenced
this pull request
Oct 9, 2023
Summary: X-link: facebook/react-native#40746 This feature was missing in JSC's JSI implementation, which is preventing from rolling out NativeState-based features in React Native. Changelog: [General][Added] JSC support for the NativeState API in JSI Reviewed By: neildhar Differential Revision: D49229022
javache
force-pushed
the
export-D49229022
branch
from
9f1a6e8 to
f130a45
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 9, 2023
Summary: This feature was missing in JSC's JSI implementation, which is preventing from rolling out NativeState-based features in React Native. Changelog: [General][Added] JSC support for the NativeState API in JSI Reviewed By: neildhar Differential Revision: D49229022
|
This pull request was exported from Phabricator. Differential Revision: D49229022 |
Base commit: 44f5989 |
javache
force-pushed
the
export-D49229022
branch
from
f130a45 to
106f932
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49229022 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 10, 2023
Summary: X-link: facebook/hermes#1151 This feature was missing in JSC's JSI implementation, which is preventing from rolling out NativeState-based features in React Native. Changelog: [General][Added] JSC support for the NativeState API in JSI Reviewed By: neildhar Differential Revision: D49229022
javache
added a commit
to javache/hermes
that referenced
this pull request
Oct 10, 2023
Summary: X-link: facebook/react-native#40746 This feature was missing in JSC's JSI implementation, which is preventing from rolling out NativeState-based features in React Native. Changelog: [General][Added] JSC support for the NativeState API in JSI Reviewed By: neildhar Differential Revision: D49229022
javache
added a commit
to javache/hermes
that referenced
this pull request
Oct 10, 2023
Summary: X-link: facebook/react-native#40746 This feature was missing in JSC's JSI implementation, which is preventing from rolling out NativeState-based features in React Native. Changelog: [General][Added] JSC support for the NativeState API in JSI Reviewed By: neildhar Differential Revision: D49229022
javache
force-pushed
the
export-D49229022
branch
from
106f932 to
da257c8
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 10, 2023
Summary: X-link: facebook/hermes#1151 This feature was missing in JSC's JSI implementation, which is preventing from rolling out NativeState-based features in React Native. Changelog: [General][Added] JSC support for the NativeState API in JSI Reviewed By: neildhar Differential Revision: D49229022
Summary: X-link: facebook/hermes#1151 This feature was missing in JSC's JSI implementation, which is preventing from rolling out NativeState-based features in React Native. Changelog: [General][Added] JSC support for the NativeState API in JSI Reviewed By: neildhar Differential Revision: D49229022
|
This pull request was exported from Phabricator. Differential Revision: D49229022 |
javache
added a commit
to javache/hermes
that referenced
this pull request
Oct 10, 2023
Summary: X-link: facebook/react-native#40746 This feature was missing in JSC's JSI implementation, which is preventing from rolling out NativeState-based features in React Native. Changelog: [General][Added] JSC support for the NativeState API in JSI Reviewed By: neildhar Differential Revision: D49229022
javache
force-pushed
the
export-D49229022
branch
from
da257c8 to
844eb12
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49229022 |
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Oct 10, 2023
Summary: Pull Request resolved: #1151 X-link: facebook/react-native#40746 This feature was missing in JSC's JSI implementation, which is preventing from rolling out NativeState-based features in React Native. Changelog: [General][Added] JSC support for the NativeState API in JSI Reviewed By: neildhar Differential Revision: D49229022 fbshipit-source-id: 1787c1d1b4803212d84da8f55b7d5a460a9d33c2
|
This pull request was successfully merged by @javache in 7b7f128. When will my fix make it into a release? | Upcoming Releases |
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Nov 8, 2023
Summary: Original Author: pieterdb@meta.com Original Git: 2b4f949 Original Reviewed By: neildhar Original Revision: D49229022 Pull Request resolved: #1151 X-link: facebook/react-native#40746 This feature was missing in JSC's JSI implementation, which is preventing from rolling out NativeState-based features in React Native. Changelog: [General][Added] JSC support for the NativeState API in JSI Reviewed By: tmikov Differential Revision: D50992853 fbshipit-source-id: 4b3c57745a9103204c1da30158c0d293d0c8e590
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This feature was missing in JSC's JSI implementation, which is preventing from rolling out NativeState-based features in React Native.
Changelog: [General][Added] JSC support for the NativeState API in JSI
Reviewed By: neildhar
Differential Revision: D49229022