refactor: removed Object.es8 {entries, values}
from js polyfills
#40747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Both
hermes
andJSC
supportsObject.{values & entries}
, so this polyfills aren't used any more.Changelog:
[GENERAL][REMOVED]: removed
Object.{values & entries}
from polyfillsTest Plan:
hermes
tests: https://github.com/facebook/hermes/blob/main/test/hermes/object-functions.js#L256console.log(Object.entries.toString());
and verify that this is[native code]