Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed Object.es8 {entries, values} from js polyfills #40747

Closed
wants to merge 1 commit into from

Conversation

ecreeth
Copy link
Contributor

@ecreeth ecreeth commented Oct 9, 2023

Summary:

Both hermes and JSC supports Object.{values & entries}, so this polyfills aren't used any more.

Changelog:

[GENERAL][REMOVED]: removed Object.{values & entries} from polyfills

Test Plan:

  1. We can confirm with hermes tests: https://github.com/facebook/hermes/blob/main/test/hermes/object-functions.js#L256
  2. Remove this polyfills and check that the code runs as expected.
  3. You can also run: console.log(Object.entries.toString()); and verify that this is [native code]

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 9, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 5d5bfe2

@robhogan
Copy link
Contributor

robhogan commented Oct 9, 2023

Thanks for this!

Also, confirmed these have both been supported on iOS JSC since 10.3, so we're good for the current RN minimum of 13.4.

@facebook-github-bot
Copy link
Contributor

@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions
Copy link

This pull request was successfully merged by @ecreeth in 04c501f.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants