Fix issue where position insets were not working with row reverse #41041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50390543 |
joevilches
force-pushed
the
export-D50390543
branch
from
a77feea to
f6e48a9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50390543 |
joevilches
force-pushed
the
export-D50390543
branch
from
f6e48a9 to
9a4fa13
Compare
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Oct 17, 2023
…cebook#41041) Summary: The last of the row-reverse issues hurray! The position insets were broken with row-reverse since we were using the main-start/main-end edges to inset from and NOT the inline-start/inline-end edges as we should. This made it so that inset in left and right were swapped and same with top and bottom (with column-reverse). The solution here is the same as the previous ones were we are migrating to using inline-start/end as the leading/trailing edge now. Differential Revision: D50390543
|
This pull request was exported from Phabricator. Differential Revision: D50390543 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Oct 17, 2023
…cebook#1431) Summary: Pull Request resolved: facebook#1431 X-link: facebook/react-native#41041 The last of the row-reverse issues hurray! The position insets were broken with row-reverse since we were using the main-start/main-end edges to inset from and NOT the inline-start/inline-end edges as we should. This made it so that inset in left and right were swapped and same with top and bottom (with column-reverse). The solution here is the same as the previous ones were we are migrating to using inline-start/end as the leading/trailing edge now. Differential Revision: D50390543 fbshipit-source-id: e42bed4f030935bff2cf12d049e13c77b3f11a18
Base commit: 9f4d66d |
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Oct 18, 2023
…cebook#1431) Summary: X-link: facebook/react-native#41041 The last of the row-reverse issues hurray! The position insets were broken with row-reverse since we were using the main-start/main-end edges to inset from and NOT the inline-start/inline-end edges as we should. This made it so that inset in left and right were swapped and same with top and bottom (with column-reverse). The solution here is the same as the previous ones were we are migrating to using inline-start/end as the leading/trailing edge now. Reviewed By: NickGerleman Differential Revision: D50390543
|
This pull request was exported from Phabricator. Differential Revision: D50390543 |
joevilches
force-pushed
the
export-D50390543
branch
from
9a4fa13 to
42dca3a
Compare
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Oct 18, 2023
…cebook#41041) Summary: X-link: facebook/yoga#1431 The last of the row-reverse issues hurray! The position insets were broken with row-reverse since we were using the main-start/main-end edges to inset from and NOT the inline-start/inline-end edges as we should. This made it so that inset in left and right were swapped and same with top and bottom (with column-reverse). The solution here is the same as the previous ones were we are migrating to using inline-start/end as the leading/trailing edge now. Reviewed By: NickGerleman Differential Revision: D50390543
…cebook#41041) Summary: X-link: facebook/yoga#1431 The last of the row-reverse issues hurray! The position insets were broken with row-reverse since we were using the main-start/main-end edges to inset from and NOT the inline-start/inline-end edges as we should. This made it so that inset in left and right were swapped and same with top and bottom (with column-reverse). The solution here is the same as the previous ones were we are migrating to using inline-start/end as the leading/trailing edge now. Reviewed By: NickGerleman Differential Revision: D50390543
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Oct 18, 2023
…cebook#41041) Summary: X-link: facebook/yoga#1431 The last of the row-reverse issues hurray! The position insets were broken with row-reverse since we were using the main-start/main-end edges to inset from and NOT the inline-start/inline-end edges as we should. This made it so that inset in left and right were swapped and same with top and bottom (with column-reverse). The solution here is the same as the previous ones were we are migrating to using inline-start/end as the leading/trailing edge now. Reviewed By: NickGerleman Differential Revision: D50390543
joevilches
force-pushed
the
export-D50390543
branch
from
42dca3a to
8dc06e5
Compare
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Oct 18, 2023
…cebook#1431) Summary: X-link: facebook/react-native#41041 The last of the row-reverse issues hurray! The position insets were broken with row-reverse since we were using the main-start/main-end edges to inset from and NOT the inline-start/inline-end edges as we should. This made it so that inset in left and right were swapped and same with top and bottom (with column-reverse). The solution here is the same as the previous ones were we are migrating to using inline-start/end as the leading/trailing edge now. Reviewed By: NickGerleman Differential Revision: D50390543
|
This pull request was exported from Phabricator. Differential Revision: D50390543 |
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Oct 18, 2023
…cebook#1431) Summary: X-link: facebook/react-native#41041 The last of the row-reverse issues hurray! The position insets were broken with row-reverse since we were using the main-start/main-end edges to inset from and NOT the inline-start/inline-end edges as we should. This made it so that inset in left and right were swapped and same with top and bottom (with column-reverse). The solution here is the same as the previous ones were we are migrating to using inline-start/end as the leading/trailing edge now. Reviewed By: NickGerleman Differential Revision: D50390543
joevilches
force-pushed
the
export-D50390543
branch
from
8dc06e5 to
5525758
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50390543 |
|
This pull request has been merged in 25575e5. |
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Oct 19, 2023
) Summary: Pull Request resolved: #1431 X-link: facebook/react-native#41041 The last of the row-reverse issues hurray! The position insets were broken with row-reverse since we were using the main-start/main-end edges to inset from and NOT the inline-start/inline-end edges as we should. This made it so that inset in left and right were swapped and same with top and bottom (with column-reverse). The solution here is the same as the previous ones were we are migrating to using inline-start/end as the leading/trailing edge now. Reviewed By: NickGerleman Differential Revision: D50390543 fbshipit-source-id: b714deab8489fbe11f7f6db21e4aad3b3aa314b3
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Oct 19, 2023
Summary: X-link: facebook/yoga#1431 X-link: facebook/react-native#41041 The last of the row-reverse issues hurray! The position insets were broken with row-reverse since we were using the main-start/main-end edges to inset from and NOT the inline-start/inline-end edges as we should. This made it so that inset in left and right were swapped and same with top and bottom (with column-reverse). The solution here is the same as the previous ones were we are migrating to using inline-start/end as the leading/trailing edge now. Reviewed By: NickGerleman Differential Revision: D50390543 fbshipit-source-id: b714deab8489fbe11f7f6db21e4aad3b3aa314b3
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Oct 30, 2023
…cebook#41041) Summary: X-link: facebook/yoga#1431 Pull Request resolved: facebook#41041 The last of the row-reverse issues hurray! The position insets were broken with row-reverse since we were using the main-start/main-end edges to inset from and NOT the inline-start/inline-end edges as we should. This made it so that inset in left and right were swapped and same with top and bottom (with column-reverse). The solution here is the same as the previous ones were we are migrating to using inline-start/end as the leading/trailing edge now. Reviewed By: NickGerleman Differential Revision: D50390543 fbshipit-source-id: b714deab8489fbe11f7f6db21e4aad3b3aa314b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D50390543
The last of the row-reverse issues hurray!
The position insets were broken with row-reverse since we were using the main-start/main-end edges to inset from and NOT the inline-start/inline-end edges as we should. This made it so that inset in left and right were swapped and same with top and bottom (with column-reverse). The solution here is the same as the previous ones were we are migrating to using inline-start/end as the leading/trailing edge now.