[RN][CI] Make hermes build more robust to avoid cache poisoning #41076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
cipolleschi
force-pushed
the
cipolleschi/make_hermes_build_more_robust
branch
from
4860521 to
12e5854
Compare
Base commit: 0a8639c |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 0b8fd74. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Oct 30, 2023
Summary: In one of the latests commits on main, Hermes failed somehow to build dSYMs in some slices. However, the slices were cached (so the cache is poisoned) and the overall process failed. With this change, we aim to make the slice's build process fail if the dSYM or the actual framework is not built properly, before caching, so they are not poisoned ## Changelog: [Internal] - Fail the build if dSYM or hermes.frameworks are not built Pull Request resolved: facebook#41076 Test Plan: CircleCI is green Reviewed By: huntie Differential Revision: D50453598 Pulled By: cipolleschi fbshipit-source-id: 06bf16ef1472bd9bc9825977b817445272477a10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In one of the latests commits on main, Hermes failed somehow to build dSYMs in some slices.
However, the slices were cached (so the cache is poisoned) and the overall process failed.
With this change, we aim to make the slice's build process fail if the dSYM or the actual framework is not built properly, before caching, so they are not poisoned
Changelog:
[Internal] - Fail the build if dSYM or hermes.frameworks are not built
Test Plan:
CircleCI is green