Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete LazyReactPackage.getReactModuleInfoProviderViaReflection #41096

Closed
wants to merge 2 commits into from
Closed

Delete LazyReactPackage.getReactModuleInfoProviderViaReflection #41096

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f25933f
Mark LazyReactPackage as Deprecated in the new architecture of React …
mdvacca Oct 27, 2023
9d475fa
Delete LazyReactPackage.getReactModuleInfoProviderViaReflection (#41096)
mdvacca Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions packages/react-native/ReactAndroid/src/main/java/com/facebook/react/LazyReactPackage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,10 @@
import java.util.List;
import java.util.Map;

/**
* React package supporting lazy creation of native modules.
*
* <p>TODO(t11394819): Make this default and deprecate ReactPackage
*/
/** React package supporting lazy creation of native modules. */
@Deprecated(since = "This class is deprecated, please use BaseReactPackage instead.")
public abstract class LazyReactPackage implements ReactPackage {

@Deprecated
public static ReactModuleInfoProvider getReactModuleInfoProviderViaReflection(
LazyReactPackage lazyReactPackage) {
return Collections::emptyMap;
}

/**
* We return an iterable
*
Expand Down