filter out onContentSizeChange from defaultRenderScrollComponent #41113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammy-SC
force-pushed
the
export-D50451232
branch
from
cda7e5d to
628750a
Compare
facebook-github-bot
added
CLA Signed
Base commit: 0239776 |
sammy-SC
force-pushed
the
export-D50451232
branch
from
628750a to
2260dbc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50451232 |
sammy-SC
force-pushed
the
export-D50451232
branch
from
2260dbc to
7b02b7e
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Oct 23, 2023
…ebook#41113) Summary: changelog: [internal] We must prevent VirtualizedList._onContentSizeChange from being triggered by a conflicting bubbling onContentSizeChange event. For TextInput, we change the event onContentSizeChange from bubbling to direct (facebook@744fb4a). To make this safer, we need to filter out any `onContentSizeChange` event since we can't control 3rd party components from dispatching onContentSizeChange as bubbling event. Reviewed By: NickGerleman Differential Revision: D50451232
sammy-SC
force-pushed
the
export-D50451232
branch
from
7b02b7e to
4837d74
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50451232 |
…ebook#41113) Summary: changelog: [internal] We must prevent VirtualizedList._onContentSizeChange from being triggered by a conflicting bubbling onContentSizeChange event. For TextInput, we change the event onContentSizeChange from bubbling to direct (facebook@744fb4a). To make this safer, we need to filter out any `onContentSizeChange` event since we can't control 3rd party components from dispatching onContentSizeChange as bubbling event. Reviewed By: NickGerleman Differential Revision: D50451232
sammy-SC
force-pushed
the
export-D50451232
branch
from
4837d74 to
91f18d1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50451232 |
|
This pull request has been merged in e8a0f0d. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Oct 30, 2023
…ebook#41113) Summary: Pull Request resolved: facebook#41113 changelog: [internal] We must prevent VirtualizedList._onContentSizeChange from being triggered by a conflicting bubbling onContentSizeChange event. For TextInput, we change the event onContentSizeChange from bubbling to direct (facebook@744fb4a). To make this safer, we need to filter out any `onContentSizeChange` event since we can't control 3rd party components from dispatching onContentSizeChange as bubbling event. Reviewed By: NickGerleman Differential Revision: D50451232 fbshipit-source-id: b7a446e4efc9c45024d37f35cb53f2fcbb28799f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
We must prevent VirtualizedList._onContentSizeChange from being triggered by a conflicting bubbling onContentSizeChange event.
For TextInput, we change the event onContentSizeChange from bubbling to direct (744fb4a). To make this safer, we need to filter out any
onContentSizeChangeevent since we can't control 3rd party components from dispatching onContentSizeChange as bubbling event.Reviewed By: NickGerleman
Differential Revision: D50451232