Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errata supporting changes to position: static #41130

Closed
wants to merge 1 commit into from

Conversation

joevilches
Copy link
Contributor

Summary: I will use this errata to gate my changes that actually make position: static behave like the web. We have future plans to make position: relative the default again but users could still have declared certain nodes as position: static, so I think this is needed regardless.

Differential Revision: D50506915

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 20, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50506915

joevilches added a commit to joevilches/yoga that referenced this pull request Oct 20, 2023
Summary:
X-link: facebook/react-native#41130

I will use this errata to gate my changes that actually make position: static behave like the web. We have future plans to make position: relative the default again but users could still have declared certain nodes as position: static, so I think this is needed regardless.

Differential Revision: D50506915

fbshipit-source-id: fcdbed46c07e681376ed19677cf0a40b448da421
@analysis-bot
Copy link

analysis-bot commented Oct 20, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,657,324 +8,158
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,039,004 +8,155
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: e5a91d7
Branch: main

Summary:
X-link: facebook/yoga#1434


I will use this errata to gate my changes that actually make position: static behave like the web. We have future plans to make position: relative the default again but users could still have declared certain nodes as position: static, so I think this is needed regardless.

Reviewed By: NickGerleman

Differential Revision: D50506915
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50506915

joevilches added a commit to joevilches/yoga that referenced this pull request Oct 23, 2023
Summary:
Pull Request resolved: facebook#1434

X-link: facebook/react-native#41130

I will use this errata to gate my changes that actually make position: static behave like the web. We have future plans to make position: relative the default again but users could still have declared certain nodes as position: static, so I think this is needed regardless.

Reviewed By: NickGerleman

Differential Revision: D50506915

fbshipit-source-id: 3a72743a30710c64b8eecfe8e08e613f46e62112
@github-actions
Copy link

This pull request was successfully merged by @joevilches in 60297d5.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Oct 24, 2023
facebook-github-bot pushed a commit to facebook/litho that referenced this pull request Oct 24, 2023
Summary:
X-link: facebook/yoga#1434

X-link: facebook/react-native#41130

I will use this errata to gate my changes that actually make position: static behave like the web. We have future plans to make position: relative the default again but users could still have declared certain nodes as position: static, so I think this is needed regardless.

Reviewed By: NickGerleman

Differential Revision: D50506915

fbshipit-source-id: b0d9e6883167de6ff002352c9288053324464cb9
facebook-github-bot pushed a commit to facebook/yoga that referenced this pull request Oct 24, 2023
Summary:
Pull Request resolved: #1434

X-link: facebook/react-native#41130

I will use this errata to gate my changes that actually make position: static behave like the web. We have future plans to make position: relative the default again but users could still have declared certain nodes as position: static, so I think this is needed regardless.

Reviewed By: NickGerleman

Differential Revision: D50506915

fbshipit-source-id: b0d9e6883167de6ff002352c9288053324464cb9
Othinn pushed a commit to Othinn/react-native that referenced this pull request Oct 30, 2023
Summary:
X-link: facebook/yoga#1434

Pull Request resolved: facebook#41130

I will use this errata to gate my changes that actually make position: static behave like the web. We have future plans to make position: relative the default again but users could still have declared certain nodes as position: static, so I think this is needed regardless.

Reviewed By: NickGerleman

Differential Revision: D50506915

fbshipit-source-id: b0d9e6883167de6ff002352c9288053324464cb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants