Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fabric: clean up oldChildShadowView when handle Insert mount #41155

Conversation

zhongwuzw
Copy link
Contributor

Summary:

We don't need to get oldChildShadowView when we handle the insert mount. So we can remove it.

Changelog:

[IOS] [CHANGED] - Fabric: clean up oldChildShadowView when handling Insert mount

Test Plan:

None.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 23, 2023
@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 25, 2023
@facebook-github-bot
Copy link
Contributor

@javache merged this pull request in e167ac9.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Oct 30, 2023
…k#41155)

Summary:
We don't need to get oldChildShadowView when we handle the insert mount. So we can remove it.

## Changelog:

[IOS] [CHANGED] - Fabric: clean up oldChildShadowView when handling Insert mount

Pull Request resolved: facebook#41155

Test Plan: None.

Reviewed By: sammy-SC

Differential Revision: D50554037

Pulled By: javache

fbshipit-source-id: 3250b6bbe119d800f05f39f790dc6949357d4f27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants