Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attempt to query Maven Central if project has react.internal.mavenLocalRepo #41175

Closed
wants to merge 1 commit into from

Conversation

cortinico
Copy link
Contributor

Summary:
This will make sure that if you specify a maven local folder with react.internal.mavenLocalRepo
you're not attempting to fetch artifacts from Maven Central.

Changelog:
[Internal] [Changed] - Do not attempt to query Maven Central if project has react.internal.mavenLocalRepo

Reviewed By: mdvacca

Differential Revision: D50600815

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Oct 24, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50600815

@analysis-bot
Copy link

analysis-bot commented Oct 24, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,653,251 +8
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,030,920 -6
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 3d1d2f5
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50600815

cortinico added a commit to cortinico/react-native that referenced this pull request Oct 25, 2023
…avenLocalRepo (facebook#41175)

Summary:

This will make sure that if you specify a maven local folder with `react.internal.mavenLocalRepo`
you're not attempting to fetch artifacts from Maven Central.

Changelog:
[Internal] [Changed] - Do not attempt to query Maven Central if project has react.internal.mavenLocalRepo

Reviewed By: mdvacca

Differential Revision: D50600815
cortinico added a commit to cortinico/react-native that referenced this pull request Oct 25, 2023
…avenLocalRepo (facebook#41175)

Summary:

This will make sure that if you specify a maven local folder with `react.internal.mavenLocalRepo`
you're not attempting to fetch artifacts from Maven Central.

Changelog:
[Internal] [Changed] - Do not attempt to query Maven Central if project has react.internal.mavenLocalRepo

Reviewed By: mdvacca

Differential Revision: D50600815
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50600815

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50600815

cortinico added a commit to cortinico/react-native that referenced this pull request Oct 25, 2023
…avenLocalRepo (facebook#41175)

Summary:

This will make sure that if you specify a maven local folder with `react.internal.mavenLocalRepo`
you're not attempting to fetch artifacts from Maven Central.

Changelog:
[Internal] [Changed] - Do not attempt to query Maven Central if project has react.internal.mavenLocalRepo

Reviewed By: mdvacca

Differential Revision: D50600815
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50600815

2 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50600815

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50600815

cortinico added a commit to cortinico/react-native that referenced this pull request Oct 26, 2023
…avenLocalRepo (facebook#41175)

Summary:

This will make sure that if you specify a maven local folder with `react.internal.mavenLocalRepo`
you're not attempting to fetch artifacts from Maven Central.

Changelog:
[Internal] [Changed] - Do not attempt to query Maven Central if project has react.internal.mavenLocalRepo

ignored-github-export-checks
bypass-github-export-checks

Reviewed By: mdvacca

Differential Revision: D50600815
cortinico added a commit to cortinico/react-native that referenced this pull request Oct 26, 2023
…avenLocalRepo (facebook#41175)

Summary:

This will make sure that if you specify a maven local folder with `react.internal.mavenLocalRepo`
you're not attempting to fetch artifacts from Maven Central.

Changelog:
[Internal] [Changed] - Do not attempt to query Maven Central if project has react.internal.mavenLocalRepo

ignored-github-export-checks
bypass-github-export-checks

Reviewed By: mdvacca

Differential Revision: D50600815
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50600815

…avenLocalRepo (facebook#41175)

Summary:

This will make sure that if you specify a maven local folder with `react.internal.mavenLocalRepo`
you're not attempting to fetch artifacts from Maven Central.

Changelog:
[Internal] [Changed] - Do not attempt to query Maven Central if project has react.internal.mavenLocalRepo

ignored-github-export-checks
bypass-github-export-checks

Reviewed By: mdvacca

Differential Revision: D50600815
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50600815

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 26, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1a7a677.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Oct 30, 2023
…avenLocalRepo (facebook#41175)

Summary:
Pull Request resolved: facebook#41175

This will make sure that if you specify a maven local folder with `react.internal.mavenLocalRepo`
you're not attempting to fetch artifacts from Maven Central.

Changelog:
[Internal] [Changed] - Do not attempt to query Maven Central if project has react.internal.mavenLocalRepo

ignored-github-export-checks
bypass-github-export-checks

Reviewed By: mdvacca

Differential Revision: D50600815

fbshipit-source-id: f429c2ae9d7204e4aa2cb29357983c0dc3a1aab6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants