Fix running iOS timers when the proximity sensor is engaged #41262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the proximity sensor is engaged and it detects "close", the screen is disabled so timers stop working. Treat the close proximity status as if the app went into the background so CADisplayLink based timers are not used.
facebook-github-bot
added
CLA Signed
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
/rebase - this comment automatically rebase this PR on top of main. |
|
This pull request was successfully merged by @saghul in 79eac96. When will my fix make it into a release? | Upcoming Releases |
|
Thank you for merging this so quickly! |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…#41262) Summary: When the proximity sensor is engaged and it detects "close", the screen is disabled so timers stop working. Treat the close proximity status as if the app went into the background so CADisplayLink based timers are not used. bypass-github-export-checks ## Changelog: [iOS] [Fixed] - Fix running timers when the proximity sensor detects close Pull Request resolved: facebook#41262 Reviewed By: dmytrorykun Differential Revision: D50839017 Pulled By: cipolleschi fbshipit-source-id: 3f7dc47d346eb88b687c8219fc905cf2a42262fe
joosissimo
added a commit
to gracetech-services/jitsi-meet
that referenced
this pull request
Jun 13, 2024
patch not needed on react-native 0.74 (fixed in facebook/react-native#41262)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When the proximity sensor is engaged and it detects "close", the screen is disabled so timers stop working. Treat the close proximity status as if the app went into the background so CADisplayLink based timers are not used.
Changelog:
[iOS] [Fixed] - Fix running timers when the proximity sensor detects close
Test Plan: