Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hook up RCTDeprecation to [RCTBridgeModule bridge] #41415

Closed
wants to merge 5 commits into from

Conversation

philIip
Copy link
Contributor

@philIip philIip commented Nov 11, 2023

Summary:
Changelog: [iOS][Deprecated]

an example of RCT_DEPRECATION in action. you will get a build time warning if RCT_DEPRECATED_DECLARATIONS is enabled.

Differential Revision: D51184572

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Nov 11, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51184572

@analysis-bot
Copy link

analysis-bot commented Nov 11, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,646,675 +4
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,034,083 +7
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 917fd25
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51184572

philIip added a commit to philIip/react-native that referenced this pull request Nov 11, 2023
Summary:

Changelog: [iOS][Deprecated]

an example of RCT_DEPRECATION in action. you will get a build time warning if `RCT_DEPRECATED_DECLARATIONS` is enabled.

Differential Revision: D51184572
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51184572

philIip added a commit to philIip/react-native that referenced this pull request Nov 11, 2023
Summary:

Changelog: [iOS][Deprecated]

an example of RCT_DEPRECATION in action. you will get a build time warning if `RCT_DEPRECATED_DECLARATIONS` is enabled.

Differential Revision: D51184572
@philIip philIip force-pushed the export-D51184572 branch 2 times, most recently from dbd6cc1 to 8263422 Compare November 14, 2023 01:02
philIip added a commit to philIip/react-native that referenced this pull request Nov 14, 2023
Summary:

Changelog: [iOS][Deprecated]

an example of RCT_DEPRECATION in action. you will get a build time warning if `RCT_DEPRECATED_DECLARATIONS` is enabled.

Reviewed By: cipolleschi

Differential Revision: D51184572
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51184572

philIip added a commit to philIip/react-native that referenced this pull request Nov 14, 2023
Summary:

Changelog: [iOS][Deprecated]

an example of RCT_DEPRECATION in action. you will get a build time warning if `RCT_DEPRECATED_DECLARATIONS` is enabled.

Reviewed By: cipolleschi

Differential Revision: D51184572
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51184572

philIip added a commit to philIip/react-native that referenced this pull request Nov 14, 2023
Summary:

Changelog: [iOS][Deprecated]

an example of RCT_DEPRECATION in action. you will get a build time warning if `RCT_DEPRECATED_DECLARATIONS` is enabled.

Reviewed By: cipolleschi

Differential Revision: D51184572
@philIip philIip force-pushed the export-D51184572 branch 2 times, most recently from aaafebf to f5c8d77 Compare November 14, 2023 21:05
philIip added a commit to philIip/react-native that referenced this pull request Nov 14, 2023
Summary:

Changelog: [iOS][Deprecated]

an example of RCT_DEPRECATION in action. you will get a build time warning if `RCT_DEPRECATED_DECLARATIONS` is enabled.

Reviewed By: cipolleschi

Differential Revision: D51184572
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51184572

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51184572

philIip added a commit to philIip/react-native that referenced this pull request Nov 14, 2023
Summary:

Changelog: [iOS][Deprecated]

an example of RCT_DEPRECATION in action. you will get a build time warning if `RCT_DEPRECATED_DECLARATIONS` is enabled.

Reviewed By: cipolleschi

Differential Revision: D51184572
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51184572

philIip added a commit to philIip/react-native that referenced this pull request Nov 16, 2023
Summary:

Changelog: [iOS][Deprecated]

an example of RCT_DEPRECATION in action. you will get a build time warning if `RCT_DEPRECATED_DECLARATIONS` is enabled.

Reviewed By: cipolleschi

Differential Revision: D51184572
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51184572

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51184572

philIip added a commit to philIip/react-native that referenced this pull request Nov 17, 2023
Summary:

Changelog: [iOS][Deprecated]

an example of RCT_DEPRECATION in action. you will get a build time warning if `RCT_DEPRECATED_DECLARATIONS` is enabled.

Reviewed By: cipolleschi

Differential Revision: D51184572
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51184572

philIip added a commit to philIip/react-native that referenced this pull request Nov 18, 2023
Summary:

Changelog: [iOS][Deprecated]

an example of RCT_DEPRECATION in action. you will get a build time warning if `RCT_DEPRECATED_DECLARATIONS` is enabled.

Reviewed By: cipolleschi

Differential Revision: D51184572
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51184572

philIip added a commit to philIip/react-native that referenced this pull request Nov 18, 2023
Summary:

Changelog: [iOS][Deprecated]

an example of RCT_DEPRECATION in action. you will get a build time warning if `RCT_DEPRECATED_DECLARATIONS` is enabled.

Reviewed By: cipolleschi

Differential Revision: D51184572
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51184572

philIip added a commit to philIip/react-native that referenced this pull request Nov 18, 2023
Summary:

Changelog: [iOS][Deprecated]

an example of RCT_DEPRECATION in action. you will get a build time warning if `RCT_DEPRECATED_DECLARATIONS` is enabled.

Reviewed By: cipolleschi

Differential Revision: D51184572
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51184572

philIip added a commit to philIip/react-native that referenced this pull request Nov 18, 2023
Summary:

Changelog: [iOS][Deprecated]

an example of RCT_DEPRECATION in action. you will get a build time warning if `RCT_DEPRECATED_DECLARATIONS` is enabled.

Reviewed By: cipolleschi

Differential Revision: D51184572
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51184572

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51184572

Summary:

Changelog: [iOS][something]

Creating a new top level directory for Apple platform specific code.

Reviewed By: christophpurrer

Differential Revision: D51170984
Summary:

Changelog: [iOS][Added]

creating a top level directory for shared lightweight utility functions

open to suggs on naming and rules we want to enforce

Reviewed By: shwanton, christophpurrer

Differential Revision: D51170983
Summary:

Changelog: [Internal]

BUCK boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Reviewed By: cipolleschi

Differential Revision: D51101009
Summary:

Changelog: [Internal]

cocoapods boilerplate to integrate the first RCTFoundation library. decided to split this up so we can reference it easily in the future when adding new libs

Reviewed By: cipolleschi

Differential Revision: D51184321
Summary:

Changelog: [iOS][Deprecated]

an example of RCT_DEPRECATION in action. you will get a build time warning if `RCT_DEPRECATED_DECLARATIONS` is enabled.

Reviewed By: cipolleschi

Differential Revision: D51184572
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51184572

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 19, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 9b1f8a8.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
Summary:
Pull Request resolved: facebook#41415

Changelog: [iOS][Deprecated]

an example of RCT_DEPRECATION in action. you will get a build time warning if `RCT_DEPRECATED_DECLARATIONS` is enabled.

Reviewed By: cipolleschi

Differential Revision: D51184572

fbshipit-source-id: a0bcb4c69e63620bbdf2e2a7afb25c649fcaa100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants