Remove pending records when unobserving a target in IntersectionObserver #41450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51256827 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 13, 2023
…ver (facebook#41450) Summary: `IntersectionObserver` shouldn't report entries for targets that are no longer being observed by the observer. This wasn't the case before because it was possible to create an intersection observer entry, then unobserve the target and then dispatch the pending entries (including the unobserved target). This fixes that issue to align with Web browsers. Changelog: [internal] Differential Revision: D51256827
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 13, 2023
…ver (facebook#41450) Summary: `IntersectionObserver` shouldn't report entries for targets that are no longer being observed by the observer. This wasn't the case before because it was possible to create an intersection observer entry, then unobserve the target and then dispatch the pending entries (including the unobserved target). This fixes that issue to align with Web browsers. Changelog: [internal] Differential Revision: D51256827
Base commit: 686f83e |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 14, 2023
…ver (facebook#41450) Summary: `IntersectionObserver` shouldn't report entries for targets that are no longer being observed by the observer. This wasn't the case before because it was possible to create an intersection observer entry, then unobserve the target and then dispatch the pending entries (including the unobserved target). This fixes that issue to align with Web browsers. Changelog: [internal] Differential Revision: D51256827
rubennorte
force-pushed
the
export-D51256827
branch
from
b686149 to
8a73a42
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51256827 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 14, 2023
…ver (facebook#41450) Summary: `IntersectionObserver` shouldn't report entries for targets that are no longer being observed by the observer. This wasn't the case before because it was possible to create an intersection observer entry, then unobserve the target and then dispatch the pending entries (including the unobserved target). This fixes that issue to align with Web browsers. Changelog: [internal] Differential Revision: D51256827
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 14, 2023
…ver (facebook#41450) Summary: `IntersectionObserver` shouldn't report entries for targets that are no longer being observed by the observer. This wasn't the case before because it was possible to create an intersection observer entry, then unobserve the target and then dispatch the pending entries (including the unobserved target). This fixes that issue to align with Web browsers. Changelog: [internal] Differential Revision: D51256827
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 14, 2023
…ver (facebook#41450) Summary: `IntersectionObserver` shouldn't report entries for targets that are no longer being observed by the observer. This wasn't the case before because it was possible to create an intersection observer entry, then unobserve the target and then dispatch the pending entries (including the unobserved target). This fixes that issue to align with Web browsers. Changelog: [internal] Differential Revision: D51256827
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 14, 2023
…ver (facebook#41450) Summary: `IntersectionObserver` shouldn't report entries for targets that are no longer being observed by the observer. This wasn't the case before because it was possible to create an intersection observer entry, then unobserve the target and then dispatch the pending entries (including the unobserved target). This fixes that issue to align with Web browsers. Changelog: [internal] Reviewed By: rshest Differential Revision: D51256827
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 14, 2023
…ver (facebook#41450) Summary: `IntersectionObserver` shouldn't report entries for targets that are no longer being observed by the observer. This wasn't the case before because it was possible to create an intersection observer entry, then unobserve the target and then dispatch the pending entries (including the unobserved target). This fixes that issue to align with Web browsers. Changelog: [internal] Reviewed By: rshest Differential Revision: D51256827
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 14, 2023
…ver (facebook#41450) Summary: `IntersectionObserver` shouldn't report entries for targets that are no longer being observed by the observer. This wasn't the case before because it was possible to create an intersection observer entry, then unobserve the target and then dispatch the pending entries (including the unobserved target). This fixes that issue to align with Web browsers. Changelog: [internal] Reviewed By: rshest Differential Revision: D51256827
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 14, 2023
…ver (facebook#41450) Summary: `IntersectionObserver` shouldn't report entries for targets that are no longer being observed by the observer. This wasn't the case before because it was possible to create an intersection observer entry, then unobserve the target and then dispatch the pending entries (including the unobserved target). This fixes that issue to align with Web browsers. Changelog: [internal] Reviewed By: rshest Differential Revision: D51256827
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 14, 2023
…ver (facebook#41450) Summary: `IntersectionObserver` shouldn't report entries for targets that are no longer being observed by the observer. This wasn't the case before because it was possible to create an intersection observer entry, then unobserve the target and then dispatch the pending entries (including the unobserved target). This fixes that issue to align with Web browsers. Changelog: [internal] Reviewed By: rshest Differential Revision: D51256827
rubennorte
force-pushed
the
export-D51256827
branch
from
8a73a42 to
e2e5b03
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 14, 2023
…ver (facebook#41450) Summary: `IntersectionObserver` shouldn't report entries for targets that are no longer being observed by the observer. This wasn't the case before because it was possible to create an intersection observer entry, then unobserve the target and then dispatch the pending entries (including the unobserved target). This fixes that issue to align with Web browsers. Changelog: [internal] Reviewed By: rshest Differential Revision: D51256827
|
This pull request was exported from Phabricator. Differential Revision: D51256827 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 14, 2023
…ver (facebook#41450) Summary: `IntersectionObserver` shouldn't report entries for targets that are no longer being observed by the observer. This wasn't the case before because it was possible to create an intersection observer entry, then unobserve the target and then dispatch the pending entries (including the unobserved target). This fixes that issue to align with Web browsers. Changelog: [internal] Reviewed By: rshest Differential Revision: D51256827
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 14, 2023
…ver (facebook#41450) Summary: `IntersectionObserver` shouldn't report entries for targets that are no longer being observed by the observer. This wasn't the case before because it was possible to create an intersection observer entry, then unobserve the target and then dispatch the pending entries (including the unobserved target). This fixes that issue to align with Web browsers. Changelog: [internal] Reviewed By: rshest Differential Revision: D51256827
rubennorte
force-pushed
the
export-D51256827
branch
from
e2e5b03 to
b88e945
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 14, 2023
…ver (facebook#41450) Summary: `IntersectionObserver` shouldn't report entries for targets that are no longer being observed by the observer. This wasn't the case before because it was possible to create an intersection observer entry, then unobserve the target and then dispatch the pending entries (including the unobserved target). This fixes that issue to align with Web browsers. Changelog: [internal] Reviewed By: rshest Differential Revision: D51256827
|
This pull request was exported from Phabricator. Differential Revision: D51256827 |
… Fabric (facebook#27687) (facebook#41452) Summary: ## Summary This fixes an error in `getPublicInstanceFromInstanceHandle` where we throw an error when trying to access the public instance from the fiber of an unmounted component. This shouldn't throw but return `null` instead. ## How did you test this change? Updated unit tests. Before: <img width="969" alt="Screenshot 2023-11-10 at 15 26 14" src="https://github.com/facebook/react/assets/117921/ea161616-2775-4fab-8d74-da4bef48d09a"> After: <img width="1148" alt="Screenshot 2023-11-10 at 15 28 37" src="https://github.com/facebook/react/assets/117921/db18b918-b6b6-4925-9cfc-3b4b2f3ab92d"> DiffTrain build for commit facebook/react@6b3834a. Test Plan: Sandcastle tests Reviewed By: tyao1 Differential Revision: D51203276 Pulled By: tyao1
…k#41451) Summary: After [this change in React](facebook/react#27687), `ReactFabric.getPublicInstanceFromInternalInstanceHandle` can return `null` if the instance handle is a fiber that was unmounted (before that PR, it would throw an error). This modifies the DOM traversal API to gracefully handle that case. Changelog: [internal] Reviewed By: rshest Differential Revision: D51210455
…ver (facebook#41450) Summary: `IntersectionObserver` shouldn't report entries for targets that are no longer being observed by the observer. This wasn't the case before because it was possible to create an intersection observer entry, then unobserve the target and then dispatch the pending entries (including the unobserved target). This fixes that issue to align with Web browsers. Changelog: [internal] Reviewed By: rshest Differential Revision: D51256827
rubennorte
force-pushed
the
export-D51256827
branch
from
b88e945 to
b9eb6f6
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Nov 14, 2023
…ver (facebook#41450) Summary: `IntersectionObserver` shouldn't report entries for targets that are no longer being observed by the observer. This wasn't the case before because it was possible to create an intersection observer entry, then unobserve the target and then dispatch the pending entries (including the unobserved target). This fixes that issue to align with Web browsers. Changelog: [internal] Reviewed By: rshest Differential Revision: D51256827
|
This pull request was exported from Phabricator. Differential Revision: D51256827 |
|
This pull request has been merged in a493ea4. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…ver (facebook#41450) Summary: Pull Request resolved: facebook#41450 `IntersectionObserver` shouldn't report entries for targets that are no longer being observed by the observer. This wasn't the case before because it was possible to create an intersection observer entry, then unobserve the target and then dispatch the pending entries (including the unobserved target). This fixes that issue to align with Web browsers. Changelog: [internal] Reviewed By: rshest Differential Revision: D51256827 fbshipit-source-id: 28035f00bcb05a8ca53140719019032b3399436c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
IntersectionObservershouldn't report entries for targets that are no longer being observed by the observer. This wasn't the case before because it was possible to create an intersection observer entry, then unobserve the target and then dispatch the pending entries (including the unobserved target). This fixes that issue to align with Web browsers.Changelog: [internal]
Differential Revision: D51256827