Fix build_codegen! not finding @react-native/codegen in pnpm setups
#41456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`build_codegen!` currently assumes that `@react-native/codegen` gets installed next to `react-native`. In a pnpm setup, it's found under `/~/react-native/node_modules/@react-native/codegen` instead. However, as @dmytrorykun pointed out, we don't actually need to build it outside of this repository.
facebook-github-bot
added
CLA Signed
This was referenced Nov 13, 2023
fortmarek
approved these changes
Dec 7, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
build_codegen!currently assumes that@react-native/codegengets installed next toreact-native. In a pnpm setup, it's found under/~/react-native/node_modules/@react-native/codegeninstead.However, as @dmytrorykun pointed out, we don't actually need to build it outside of this repository.
Cherry-picks 3dd6a83
Changelog:
[GENERAL] [FIXED] -
@react-native/codegenshouldn't be built unless it's in the repo — fixespod installfailures in pnpm setupsTest Plan:
We have a patched version of
react-nativeworking in a pnpm setup here: microsoft/rnx-kit#2811