Create genrule to generate appmodules.so #41466

RSNara · 2023-11-13T22:18:27Z

Summary:

Context

In open source, all apps use the same turbomodulemanager delegate (i.e: the default delegate).

This diff introduces the buck infra that makes the oss default delegate work for meta apps.

Concretely, we are going to make React Native use the same delegate for all Meta apps.

Each Meta app will:

At build time, generate a unique TMProvider map
At app init time, initialize the default delegate with the TMProvider map.

Implementation

Step #1: At build time, generate a unique TMProvider map

Insight: Buck genrules can accept, as input, the output of a buck query.

So, here's how we get this done:

Buck query (i.e: input to Genrule): Given the app's deps, query all the schemas in the app.
Genrule: Read the schemas to generate the TMProvider map. The TMProvider map will also contain all the app's C++ module codegen.

Concretely:

This diff introduces a macro: rn_codegen_appmodules(deps).
rn_codegen_appmodules(deps) generates appmodules.so, which contains the TMProvider map.

Step #2: At app init time, initialize the default delegate with the TMProvider map.

This is how we'll initialize the DefaultTurboModuleManagerDelegate:

DefaultTurboModuleManagerDelegate will load appmodules.so during init.
When loaded, appmodules.so will assign the code-generated TMProvider map to DefaultTurboModuleManagerDelegate.

Impact

This should allow us to:

Get one step closer to getting rid of the js1 build turbomodule-manager-delegates --target <app> script
Remove the TurboModuleManagerDelegate from React Native's public API. (Because we use one delegate for all React Native apps in Meta and OSS)

Differential Revision: D50988397

facebook-github-bot · 2023-11-13T22:18:58Z

This pull request was exported from Phabricator. Differential Revision: D50988397

analysis-bot · 2023-11-13T22:46:10Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	17,663,231	+16,564
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	21,046,534	+12,461
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 9b1f8a8
Branch: main

facebook-github-bot · 2023-11-14T15:17:34Z

This pull request was exported from Phabricator. Differential Revision: D50988397

facebook-github-bot · 2023-11-15T21:23:45Z

This pull request was exported from Phabricator. Differential Revision: D50988397

Summary: ## Context In open source, all apps use the same turbomodulemanager delegate (i.e: the default delegate). This diff introduces the buck infra that makes the oss default delegate work for meta apps. Concretely, we are going to make React Native use the same delegate for **all** Meta apps. Each Meta app will: 1. At build time, generate a unique TMProvider map 2. At app init time, initialize the default delegate with the TMProvider map. ## Implementation **Step facebook#1:** At build time, generate a unique TMProvider map **Insight:** Buck genrules can accept, as input, the output of a buck query. So, here's how we get this done: 1. Buck query (i.e: input to Genrule): Given the app's deps, query all the schemas in the app. 2. Genrule: Read the schemas to generate the TMProvider map. The TMProvider map will also contain **all** the app's C++ module codegen. Concretely: 1. This diff introduces a macro: rn_codegen_appmodules(deps). 2. rn_codegen_appmodules(deps) generates appmodules.so, which contains the TMProvider map. **Step facebook#2:** At app init time, initialize the default delegate with the TMProvider map. This is how we'll initialize the DefaultTurboModuleManagerDelegate: 1. DefaultTurboModuleManagerDelegate will load appmodules.so during init. 2. When loaded, appmodules.so will assign the code-generated TMProvider map to DefaultTurboModuleManagerDelegate. ## Impact This should allow us to: 1. Get one step closer to getting rid of the `js1 build turbomodule-manager-delegates --target <app>` script 3. Remove the TurboModuleManagerDelegate from React Native's public API. (Because we use one delegate for all React Native apps in Meta and OSS) Reviewed By: mdvacca Differential Revision: D50988397

facebook-github-bot · 2023-11-15T22:44:09Z

This pull request was exported from Phabricator. Differential Revision: D50988397

Summary: ## Context In open source, all apps use the same turbomodulemanager delegate (i.e: the default delegate). This diff introduces the buck infra that makes the oss default delegate work for meta apps. Concretely, we are going to make React Native use the same delegate for **all** Meta apps. Each Meta app will: 1. At build time, generate a unique TMProvider map 2. At app init time, initialize the default delegate with the TMProvider map. ## Implementation **Step facebook#1:** At build time, generate a unique TMProvider map **Insight:** Buck genrules can accept, as input, the output of a buck query. So, here's how we get this done: 1. Buck query (i.e: input to Genrule): Given the app's deps, query all the schemas in the app. 2. Genrule: Read the schemas to generate the TMProvider map. The TMProvider map will also contain **all** the app's C++ module codegen. Concretely: 1. This diff introduces a macro: rn_codegen_appmodules(deps). 2. rn_codegen_appmodules(deps) generates appmodules.so, which contains the TMProvider map. **Step facebook#2:** At app init time, initialize the default delegate with the TMProvider map. This is how we'll initialize the DefaultTurboModuleManagerDelegate: 1. DefaultTurboModuleManagerDelegate will load appmodules.so during init. 2. When loaded, appmodules.so will assign the code-generated TMProvider map to DefaultTurboModuleManagerDelegate. ## Impact This should allow us to: 1. Get one step closer to getting rid of the `js1 build turbomodule-manager-delegates --target <app>` script 3. Remove the TurboModuleManagerDelegate from React Native's public API. (Because we use one delegate for all React Native apps in Meta and OSS) Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D50988397

facebook-github-bot · 2023-11-17T00:18:27Z

This pull request was exported from Phabricator. Differential Revision: D50988397

Summary: ## Context In open source, all apps use the same turbomodulemanager delegate (i.e: the default delegate). This diff introduces the buck infra that makes the oss default delegate work for meta apps. Concretely, we are going to make React Native use the same delegate for **all** Meta apps. Each Meta app will: 1. At build time, generate a unique TMProvider map 2. At app init time, initialize the default delegate with the TMProvider map. ## Implementation **Step facebook#1:** At build time, generate a unique TMProvider map **Insight:** Buck genrules can accept, as input, the output of a buck query. So, here's how we get this done: 1. Buck query (i.e: input to Genrule): Given the app's deps, query all the schemas in the app. 2. Genrule: Read the schemas to generate the TMProvider map. The TMProvider map will also contain **all** the app's C++ module codegen. Concretely: 1. This diff introduces a macro: rn_codegen_appmodules(deps). 2. rn_codegen_appmodules(deps) generates appmodules.so, which contains the TMProvider map. **Step facebook#2:** At app init time, initialize the default delegate with the TMProvider map. This is how we'll initialize the DefaultTurboModuleManagerDelegate: 1. DefaultTurboModuleManagerDelegate will load appmodules.so during init. 2. When loaded, appmodules.so will assign the code-generated TMProvider map to DefaultTurboModuleManagerDelegate. ## Impact This should allow us to: 1. Get one step closer to getting rid of the `js1 build turbomodule-manager-delegates --target <app>` script 3. Remove the TurboModuleManagerDelegate from React Native's public API. (Because we use one delegate for all React Native apps in Meta and OSS) Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D50988397

facebook-github-bot · 2023-11-21T19:08:07Z

This pull request was exported from Phabricator. Differential Revision: D50988397

Summary: ## Context In open source, all apps use the same turbomodulemanager delegate (i.e: the default delegate). This diff introduces the buck infra that makes the oss default delegate work for meta apps. Concretely, we are going to make React Native use the same delegate for **all** Meta apps. Each Meta app will: 1. At build time, generate a unique TMProvider map 2. At app init time, initialize the default delegate with the TMProvider map. ## Implementation **Step facebook#1:** At build time, generate a unique TMProvider map **Insight:** Buck genrules can accept, as input, the output of a buck query. So, here's how we get this done: 1. Buck query (i.e: input to Genrule): Given the app's deps, query all the schemas in the app. 2. Genrule: Read the schemas to generate the TMProvider map. The TMProvider map will also contain **all** the app's C++ module codegen. Concretely: 1. This diff introduces a macro: rn_codegen_appmodules(deps). 2. rn_codegen_appmodules(deps) generates appmodules.so, which contains the TMProvider map. **Step facebook#2:** At app init time, initialize the default delegate with the TMProvider map. This is how we'll initialize the DefaultTurboModuleManagerDelegate: 1. DefaultTurboModuleManagerDelegate will load appmodules.so during init. 2. When loaded, appmodules.so will assign the code-generated TMProvider map to DefaultTurboModuleManagerDelegate. ## Impact This should allow us to: 1. Get one step closer to getting rid of the `js1 build turbomodule-manager-delegates --target <app>` script 3. Remove the TurboModuleManagerDelegate from React Native's public API. (Because we use one delegate for all React Native apps in Meta and OSS) Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D50988397

facebook-github-bot · 2023-11-21T19:08:23Z

This pull request was exported from Phabricator. Differential Revision: D50988397

Summary: ## Context In open source, all apps use the same turbomodulemanager delegate (i.e: the default delegate). This diff introduces the buck infra that makes the oss default delegate work for meta apps. Concretely, we are going to make React Native use the same delegate for **all** Meta apps. Each Meta app will: 1. At build time, generate a unique TMProvider map 2. At app init time, initialize the default delegate with the TMProvider map. ## Implementation **Step facebook#1:** At build time, generate a unique TMProvider map **Insight:** Buck genrules can accept, as input, the output of a buck query. So, here's how we get this done: 1. Buck query (i.e: input to Genrule): Given the app's deps, query all the schemas in the app. 2. Genrule: Read the schemas to generate the TMProvider map. The TMProvider map will also contain **all** the app's C++ module codegen. Concretely: 1. This diff introduces a macro: rn_codegen_appmodules(deps). 2. rn_codegen_appmodules(deps) generates appmodules.so, which contains the TMProvider map. **Step facebook#2:** At app init time, initialize the default delegate with the TMProvider map. This is how we'll initialize the DefaultTurboModuleManagerDelegate: 1. DefaultTurboModuleManagerDelegate will load appmodules.so during init. 2. When loaded, appmodules.so will assign the code-generated TMProvider map to DefaultTurboModuleManagerDelegate. ## Impact This should allow us to: 1. Get one step closer to getting rid of the `js1 build turbomodule-manager-delegates --target <app>` script 3. Remove the TurboModuleManagerDelegate from React Native's public API. (Because we use one delegate for all React Native apps in Meta and OSS) Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D50988397

facebook-github-bot · 2023-11-22T18:28:43Z

This pull request was exported from Phabricator. Differential Revision: D50988397

Summary: ## Context In open source, all apps use the same turbomodulemanager delegate (i.e: the default delegate). This diff introduces the buck infra that makes the oss default delegate work for meta apps. Concretely, we are going to make React Native use the same delegate for **all** Meta apps. Each Meta app will: 1. At build time, generate a unique TMProvider map 2. At app init time, initialize the default delegate with the TMProvider map. ## Implementation **Step facebook#1:** At build time, generate a unique TMProvider map **Insight:** Buck genrules can accept, as input, the output of a buck query. So, here's how we get this done: 1. Buck query (i.e: input to Genrule): Given the app's deps, query all the schemas in the app. 2. Genrule: Read the schemas to generate the TMProvider map. The TMProvider map will also contain **all** the app's C++ module codegen. Concretely: 1. This diff introduces a macro: rn_codegen_appmodules(deps). 2. rn_codegen_appmodules(deps) generates appmodules.so, which contains the TMProvider map. **Step facebook#2:** At app init time, initialize the default delegate with the TMProvider map. This is how we'll initialize the DefaultTurboModuleManagerDelegate: 1. DefaultTurboModuleManagerDelegate will load appmodules.so during init. 2. When loaded, appmodules.so will assign the code-generated TMProvider map to DefaultTurboModuleManagerDelegate. ## Impact This should allow us to: 1. Get one step closer to getting rid of the `js1 build turbomodule-manager-delegates --target <app>` script 3. Remove the TurboModuleManagerDelegate from React Native's public API. (Because we use one delegate for all React Native apps in Meta and OSS) Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D50988397

facebook-github-bot · 2023-11-22T18:29:04Z

This pull request was exported from Phabricator. Differential Revision: D50988397

facebook-github-bot · 2023-11-22T18:55:07Z

This pull request was exported from Phabricator. Differential Revision: D50988397

Summary: ## Context In open source, all apps use the same turbomodulemanager delegate (i.e: the default delegate). This diff introduces the buck infra that makes the oss default delegate work for meta apps. Concretely, we are going to make React Native use the same delegate for **all** Meta apps. Each Meta app will: 1. At build time, generate a unique TMProvider map 2. At app init time, initialize the default delegate with the TMProvider map. ## Implementation **Step facebook#1:** At build time, generate a unique TMProvider map **Insight:** Buck genrules can accept, as input, the output of a buck query. So, here's how we get this done: 1. Buck query (i.e: input to Genrule): Given the app's deps, query all the schemas in the app. 2. Genrule: Read the schemas to generate the TMProvider map. The TMProvider map will also contain **all** the app's C++ module codegen. Concretely: 1. This diff introduces a macro: rn_codegen_appmodules(deps). 2. rn_codegen_appmodules(deps) generates appmodules.so, which contains the TMProvider map. **Step facebook#2:** At app init time, initialize the default delegate with the TMProvider map. This is how we'll initialize the DefaultTurboModuleManagerDelegate: 1. DefaultTurboModuleManagerDelegate will load appmodules.so during init. 2. When loaded, appmodules.so will assign the code-generated TMProvider map to DefaultTurboModuleManagerDelegate. ## Impact This should allow us to: 1. Get one step closer to getting rid of the `js1 build turbomodule-manager-delegates --target <app>` script 3. Remove the TurboModuleManagerDelegate from React Native's public API. (Because we use one delegate for all React Native apps in Meta and OSS) Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D50988397

facebook-github-bot · 2023-11-22T18:55:51Z

This pull request was exported from Phabricator. Differential Revision: D50988397

facebook-github-bot · 2023-11-22T19:28:27Z

This pull request was exported from Phabricator. Differential Revision: D50988397

Summary: ## Context In open source, all apps use the same turbomodulemanager delegate (i.e: the default delegate). This diff introduces the buck infra that makes the oss default delegate work for meta apps. Concretely, we are going to make React Native use the same delegate for **all** Meta apps. Each Meta app will: 1. At build time, generate a unique TMProvider map 2. At app init time, initialize the default delegate with the TMProvider map. ## Implementation **Step facebook#1:** At build time, generate a unique TMProvider map **Insight:** Buck genrules can accept, as input, the output of a buck query. So, here's how we get this done: 1. Buck query (i.e: input to Genrule): Given the app's deps, query all the schemas in the app. 2. Genrule: Read the schemas to generate the TMProvider map. The TMProvider map will also contain **all** the app's C++ module codegen. Concretely: 1. This diff introduces a macro: rn_codegen_appmodules(deps). 2. rn_codegen_appmodules(deps) generates appmodules.so, which contains the TMProvider map. **Step facebook#2:** At app init time, initialize the default delegate with the TMProvider map. This is how we'll initialize the DefaultTurboModuleManagerDelegate: 1. DefaultTurboModuleManagerDelegate will load appmodules.so during init. 2. When loaded, appmodules.so will assign the code-generated TMProvider map to DefaultTurboModuleManagerDelegate. ## Impact This should allow us to: 1. Get one step closer to getting rid of the `js1 build turbomodule-manager-delegates --target <app>` script 3. Remove the TurboModuleManagerDelegate from React Native's public API. (Because we use one delegate for all React Native apps in Meta and OSS) Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D50988397

facebook-github-bot · 2023-11-22T19:28:37Z

This pull request was exported from Phabricator. Differential Revision: D50988397

Summary: ## Context In open source, all apps use the same turbomodulemanager delegate (i.e: the default delegate). This diff introduces the buck infra that makes the oss default delegate work for meta apps. Concretely, we are going to make React Native use the same delegate for **all** Meta apps. Each Meta app will: 1. At build time, generate a unique TMProvider map 2. At app init time, initialize the default delegate with the TMProvider map. ## Implementation **Step facebook#1:** At build time, generate a unique TMProvider map **Insight:** Buck genrules can accept, as input, the output of a buck query. So, here's how we get this done: 1. Buck query (i.e: input to Genrule): Given the app's deps, query all the schemas in the app. 2. Genrule: Read the schemas to generate the TMProvider map. The TMProvider map will also contain **all** the app's C++ module codegen. Concretely: 1. This diff introduces a macro: rn_codegen_appmodules(deps). 2. rn_codegen_appmodules(deps) generates appmodules.so, which contains the TMProvider map. **Step facebook#2:** At app init time, initialize the default delegate with the TMProvider map. This is how we'll initialize the DefaultTurboModuleManagerDelegate: 1. DefaultTurboModuleManagerDelegate will load appmodules.so during init. 2. When loaded, appmodules.so will assign the code-generated TMProvider map to DefaultTurboModuleManagerDelegate. ## Impact This should allow us to: 1. Get one step closer to getting rid of the `js1 build turbomodule-manager-delegates --target <app>` script 3. Remove the TurboModuleManagerDelegate from React Native's public API. (Because we use one delegate for all React Native apps in Meta and OSS) Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D50988397

facebook-github-bot · 2023-11-22T20:01:41Z

This pull request was exported from Phabricator. Differential Revision: D50988397

facebook-github-bot · 2023-11-22T21:58:06Z

This pull request has been merged in 3ee4b8f.

Summary: Pull Request resolved: facebook#41466 ## Context In open source, all apps use the same turbomodulemanager delegate (i.e: the default delegate). This diff introduces the buck infra that makes the oss default delegate work for meta apps. Concretely, we are going to make React Native use the same delegate for **all** Meta apps. Each Meta app will: 1. At build time, generate a unique TMProvider map 2. At app init time, initialize the default delegate with the TMProvider map. ## Implementation **Step facebook#1:** At build time, generate a unique TMProvider map **Insight:** Buck genrules can accept, as input, the output of a buck query. So, here's how we get this done: 1. Buck query (i.e: input to Genrule): Given the app's deps, query all the schemas in the app. 2. Genrule: Read the schemas to generate the TMProvider map. The TMProvider map will also contain **all** the app's C++ module codegen. Concretely: 1. This diff introduces a macro: rn_codegen_appmodules(deps). 2. rn_codegen_appmodules(deps) generates appmodules.so, which contains the TMProvider map. **Step facebook#2:** At app init time, initialize the default delegate with the TMProvider map. This is how we'll initialize the DefaultTurboModuleManagerDelegate: 1. DefaultTurboModuleManagerDelegate will load appmodules.so during init. 2. When loaded, appmodules.so will assign the code-generated TMProvider map to DefaultTurboModuleManagerDelegate. ## Impact This should allow us to: 1. Get one step closer to getting rid of the `js1 build turbomodule-manager-delegates --target <app>` script 3. Remove the TurboModuleManagerDelegate from React Native's public API. (Because we use one delegate for all React Native apps in Meta and OSS) Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D50988397 fbshipit-source-id: 0ca5dec14e2dae89ec97f5d39a182c7937c5c7bf

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Nov 13, 2023

facebook-github-bot added the fb-exported label Nov 13, 2023

RSNara force-pushed the export-D50988397 branch from ba4177c to 6e24122 Compare November 14, 2023 15:17

RSNara force-pushed the export-D50988397 branch from 6e24122 to f62d223 Compare November 15, 2023 21:23

RSNara force-pushed the export-D50988397 branch from f62d223 to e7def27 Compare November 15, 2023 22:43

RSNara force-pushed the export-D50988397 branch from e7def27 to 3040876 Compare November 17, 2023 00:18

RSNara force-pushed the export-D50988397 branch from 3040876 to de202f3 Compare November 17, 2023 19:26

RSNara force-pushed the export-D50988397 branch from 7a712fc to 81151ac Compare November 21, 2023 19:07

RSNara force-pushed the export-D50988397 branch from 81151ac to 2c67eaa Compare November 21, 2023 19:08

RSNara force-pushed the export-D50988397 branch from 2c67eaa to bbd682e Compare November 22, 2023 18:28

RSNara force-pushed the export-D50988397 branch from bbd682e to 99981c8 Compare November 22, 2023 18:28

RSNara force-pushed the export-D50988397 branch from 99981c8 to 9871eb1 Compare November 22, 2023 18:54

RSNara force-pushed the export-D50988397 branch from 9871eb1 to dc5e0e5 Compare November 22, 2023 18:55

RSNara force-pushed the export-D50988397 branch from dc5e0e5 to b4d352c Compare November 22, 2023 19:28

RSNara force-pushed the export-D50988397 branch from b4d352c to 60d1404 Compare November 22, 2023 19:28

RSNara force-pushed the export-D50988397 branch from 60d1404 to 8a827b8 Compare November 22, 2023 20:01

facebook-github-bot closed this in 3ee4b8f Nov 22, 2023

facebook-github-bot added the Merged This PR has been merged. label Nov 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create genrule to generate appmodules.so #41466

Create genrule to generate appmodules.so #41466

RSNara commented Nov 13, 2023

facebook-github-bot commented Nov 13, 2023

analysis-bot commented Nov 13, 2023 •

edited

Loading

facebook-github-bot commented Nov 14, 2023

facebook-github-bot commented Nov 15, 2023

facebook-github-bot commented Nov 15, 2023

facebook-github-bot commented Nov 17, 2023

facebook-github-bot commented Nov 21, 2023

facebook-github-bot commented Nov 21, 2023

facebook-github-bot commented Nov 22, 2023

facebook-github-bot commented Nov 22, 2023

facebook-github-bot commented Nov 22, 2023

facebook-github-bot commented Nov 22, 2023

facebook-github-bot commented Nov 22, 2023

facebook-github-bot commented Nov 22, 2023

facebook-github-bot commented Nov 22, 2023

facebook-github-bot commented Nov 22, 2023

Create genrule to generate appmodules.so #41466

Create genrule to generate appmodules.so #41466

Conversation

RSNara commented Nov 13, 2023

Context

Implementation

Impact

facebook-github-bot commented Nov 13, 2023

analysis-bot commented Nov 13, 2023 • edited Loading

facebook-github-bot commented Nov 14, 2023

facebook-github-bot commented Nov 15, 2023

facebook-github-bot commented Nov 15, 2023

facebook-github-bot commented Nov 17, 2023

facebook-github-bot commented Nov 21, 2023

facebook-github-bot commented Nov 21, 2023

facebook-github-bot commented Nov 22, 2023

facebook-github-bot commented Nov 22, 2023

facebook-github-bot commented Nov 22, 2023

facebook-github-bot commented Nov 22, 2023

facebook-github-bot commented Nov 22, 2023

facebook-github-bot commented Nov 22, 2023

facebook-github-bot commented Nov 22, 2023

facebook-github-bot commented Nov 22, 2023

analysis-bot commented Nov 13, 2023 •

edited

Loading