Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Open Debugger" action under JSC #41535

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -363,15 +363,16 @@ public void onOptionSelected() {
}
});

if (mDevSettings.isDeviceDebugEnabled()) {
// On-device JS debugging (CDP). Render action to open debugger frontend.
if (mDevSettings.isRemoteJSDebugEnabled()) {
// [Deprecated in React Native 0.73] Remote JS debugging. Handle reload
// via external JS executor. This capability will be removed in a future
// release.
mDevSettings.setRemoteJSDebugEnabled(false);
handleReloadJS();
}

// Reset the old debugger setting so no one gets stuck.
// TODO: Remove in a few weeks.
if (mDevSettings.isRemoteJSDebugEnabled()) {
mDevSettings.setRemoteJSDebugEnabled(false);
handleReloadJS();
}
if (mDevSettings.isDeviceDebugEnabled() && !mDevSettings.isRemoteJSDebugEnabled()) {
// On-device JS debugging (CDP). Render action to open debugger frontend.
options.put(
mApplicationContext.getString(R.string.catalyst_debug_open),
() ->
Expand Down