Add NDEBUG flag for Release builds for both architectures

[tjzel]

Summary:

Currently React Native defines NDEBUG flag for all pods in Fabric only. This is useful for other libraries, like Reanimated, because they have no easy way of defining their compilation flags (at least none that I know of). Therefore defining NDEBUG for both architectures would be beneficial.

Changelog:

Pick one each for the category and type tags:

[IOS] [CHANGED] - Add NDEBUG flag for Release builds for both architectures

Test Plan:

Run ruby test suite.

Notes

For the time being I just copied
prepare_pod_target_installation_results_mock
and
def prepare_installer_for_cpp_flags
to utils-test.rb since I wasn't sure how to handle the installer mock.

[facebook-github-bot]

Hi @tjzel!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cipolleschi]

To fix the tests, open the new_architecture-test.rb file and modify:

#line 124
-  assert_equal(react_core_release_config.build_settings["OTHER_CFLAGS"], "$(inherited)")
+  assert_nil(react_core_release_config.build_settings["OTHER_CFLAGS"])

#line 128
- assert_equal(yoga_release_config.build_settings["OTHER_CFLAGS"], "$(inherited)")
+ assert_nil(yoga_release_config.build_settings["OTHER_CFLAGS"])

[cipolleschi]

/rebase - this is an automatic command which will rebase automatically the PR on top of main

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cipolleschi merged this pull request in 1a0e174.