-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix init for out-of-tree platforms by passing name to CLI #41723
Conversation
Which capabilities? |
@cortinico seamless |
I’m pretty sure this is going to pass “react-native” for RN Windows if we organize like this. Don’t we already have platforms declared in React Native config to read from? |
@NickGerleman without this change |
@NickGerleman @thymikee RN Windows also has it's name defined in package.json we are reading from: https://github.com/microsoft/react-native-windows/blob/f19a9e7e8a40a2fb7086371b3f3a955e15a1d771/vnext/package.json#L2 But even passing |
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @thymikee in 547643e. When will my fix make it into a release? | Upcoming Releases |
@dmytrorykun merged this pull request in 547643e. |
…1723) Summary: To unlock ~~certain OOT platform capabilities~~ seamless `init` integration for out-of-tree platforms with CLI, we need to pass the package name to it. This change landed on 0.73 branch already: facebook#41530 Depends on facebook#41722 ## Changelog: [INTERNAL] [ADDED] - Fix init for out-of-tree platforms by passing name to CLI Pull Request resolved: facebook#41723 Test Plan: CI green Reviewed By: christophpurrer Differential Revision: D51979329 Pulled By: dmytrorykun fbshipit-source-id: 451f70dc42ae0667bc65cba2e77898c9eec8d9ec
Summary:
To unlock
certain OOT platform capabilitiesseamlessinit
integration for out-of-tree platforms with CLI, we need to pass the package name to it. This change landed on 0.73 branch already: #41530Depends on #41722
Changelog:
[INTERNAL] [ADDED] - Fix init for out-of-tree platforms by passing name to CLI
Test Plan:
CI green