Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GenerateModuleH fixture #41780

Closed

Conversation

christophpurrer
Copy link
Contributor

Summary:
This updates our test fixture with more concrete examples from:
https://github.com/facebook/react-native/blob/main/packages/rn-tester/NativeCxxModuleExample/NativeCxxModuleExample.js

Changelog: [Internal]

Differential Revision: D51804559

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51804559

@analysis-bot
Copy link

analysis-bot commented Dec 4, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,725,992 +9
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,113,209 +10
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: cd395b5
Branch: main

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Dec 4, 2023
Summary:

This updates our test fixture with more concrete examples from:
https://github.com/facebook/react-native/blob/main/packages/rn-tester/NativeCxxModuleExample/NativeCxxModuleExample.js

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D51804559
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51804559

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Dec 4, 2023
Summary:

This updates our test fixture with more concrete examples from:
https://github.com/facebook/react-native/blob/main/packages/rn-tester/NativeCxxModuleExample/NativeCxxModuleExample.js

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D51804559
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51804559

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Dec 4, 2023
Summary:

This updates our test fixture with more concrete examples from:
https://github.com/facebook/react-native/blob/main/packages/rn-tester/NativeCxxModuleExample/NativeCxxModuleExample.js

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D51804559
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51804559

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Dec 4, 2023
Summary:

This updates our test fixture with more concrete examples from:
https://github.com/facebook/react-native/blob/main/packages/rn-tester/NativeCxxModuleExample/NativeCxxModuleExample.js

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D51804559
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51804559

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51804559

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Dec 4, 2023
Summary:

This updates our test fixture with more concrete examples from:
https://github.com/facebook/react-native/blob/main/packages/rn-tester/NativeCxxModuleExample/NativeCxxModuleExample.js

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D51804559
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51804559

Summary:

This updates our test fixture with more concrete examples from:
https://github.com/facebook/react-native/blob/main/packages/rn-tester/NativeCxxModuleExample/NativeCxxModuleExample.js

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D51804559
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51804559

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 974e584.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 4, 2023
Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
Summary:
Pull Request resolved: facebook#41780

This updates our test fixture with more concrete examples from:
https://github.com/facebook/react-native/blob/main/packages/rn-tester/NativeCxxModuleExample/NativeCxxModuleExample.js

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D51804559

fbshipit-source-id: 3290bc5447e0b47551ad73f5b041e332443e71c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants