Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix adding custom ReactPackages in Kotlin template #41871

Closed
wants to merge 1 commit into from
Closed

fix: Fix adding custom ReactPackages in Kotlin template #41871

wants to merge 1 commit into from

Conversation

mrousavy
Copy link
Contributor

@mrousavy mrousavy commented Dec 9, 2023 •
edited
Loading

Summary:

The previous comment in the template used Java, this has now been updated to Kotlin.

Changelog:

[ANDROID] [Changed] - Adjust new Kotlin template to allow for registering custom Packages

Test Plan:

  1. Add custom ReactPackage in MainApplication.kt

@mrousavy
fix: Fix adding custom ReactPackages in Kotlin template
b061293 
The previous comment in the template used Java, this has now been updated to Kotlin.
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Dec 9, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,513,060 -4,094
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,891,830 -6
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: a9dd43c
Branch: main

@facebook-github-bot
Copy link
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@leonhh
Copy link

leonhh commented Dec 9, 2023

This is a duplicate of #41856

@mrousavy
Copy link
Contributor Author

oh whoops, guess Janic was faster! 😅

@cortinico
Copy link
Contributor

Closing as a duplicate of #41856

@cortinico cortinico closed this Dec 11, 2023
@cortinico cortinico added Resolution: Duplicate and removed Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rshest rshest rshest approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Resolution: Duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mrousavy @analysis-bot @facebook-github-bot @leonhh @cortinico @rshest