fix[getInternalInstanceHandleFromPublicInstance]: make it backwards compatible with previous Fabric implementation #42250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52697886 |
hoxyq
force-pushed
the
export-D52697886
branch
from
cfd54c1 to
a171893
Compare
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Jan 12, 2024
…ompatible with previous Fabric implementation (facebook#42250) Summary: Changelog: [Internal] Currently, OSS versions ofReactFabric and ReactNativeRenderer artifacts are ~2 years behind the FB version. Fabric host components store internal instance in __internalInstanceHandle field, previously they have been storing it in the field with the same name, but with one underscore in prefix: https://www.internalfb.com/code/fbsource/[79c52d10beb6]/xplat/js/react-native-github/packages/react-native/Libraries/Renderer/implementations/ReactFabric-dev.js?lines=5151 Once these artifacts will be synced, the implementation will use __internalInstanceHandle field, so we can safely remove the branch with a single underscore prefix. Reviewed By: rubennorte Differential Revision: D52697886
|
This pull request was exported from Phabricator. Differential Revision: D52697886 |
hoxyq
force-pushed
the
export-D52697886
branch
from
a171893 to
dd78558
Compare
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Jan 15, 2024
…ompatible with previous Fabric implementation (facebook#42250) Summary: Changelog: [Internal] Currently, OSS versions ofReactFabric and ReactNativeRenderer artifacts are ~2 years behind the FB version. Fabric host components store internal instance in __internalInstanceHandle field, previously they have been storing it in the field with the same name, but with one underscore in prefix: https://www.internalfb.com/code/fbsource/[79c52d10beb6]/xplat/js/react-native-github/packages/react-native/Libraries/Renderer/implementations/ReactFabric-dev.js?lines=5151 Once these artifacts will be synced, the implementation will use __internalInstanceHandle field, so we can safely remove the branch with a single underscore prefix. Reviewed By: rubennorte Differential Revision: D52697886
|
This pull request was exported from Phabricator. Differential Revision: D52697886 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Jan 15, 2024
…ackwards compatible with previous Fabric implementation (facebook#42250) Summary: Changelog: [Internal] Currently, OSS versions ofReactFabric and ReactNativeRenderer artifacts are ~2 years behind the FB version. Fabric host components store internal instance in __internalInstanceHandle field, previously they have been storing it in the field with the same name, but with one underscore in prefix: https://www.internalfb.com/code/fbsource/[79c52d10beb6]/xplat/js/react-native-github/packages/react-native/Libraries/Renderer/implementations/ReactFabric-dev.js?lines=5151 Once these artifacts will be synced, the implementation will use __internalInstanceHandle field, so we can safely remove the branch with a single underscore prefix. Reviewed By: rubennorte Differential Revision: D52697886
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Jan 15, 2024
…ompatible with previous Fabric implementation (facebook#42250) Summary: Changelog: [Internal] Currently, OSS versions ofReactFabric and ReactNativeRenderer artifacts are ~2 years behind the FB version. Fabric host components store internal instance in __internalInstanceHandle field, previously they have been storing it in the field with the same name, but with one underscore in prefix: https://www.internalfb.com/code/fbsource/[79c52d10beb6]/xplat/js/react-native-github/packages/react-native/Libraries/Renderer/implementations/ReactFabric-dev.js?lines=5151 Once these artifacts will be synced, the implementation will use __internalInstanceHandle field, so we can safely remove the branch with a single underscore prefix. Reviewed By: rubennorte Differential Revision: D52697886
hoxyq
force-pushed
the
export-D52697886
branch
from
dd78558 to
c56a41f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52697886 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Jan 15, 2024
…ackwards compatible with previous Fabric implementation (facebook#42250) Summary: Changelog: [Internal] Currently, OSS versions ofReactFabric and ReactNativeRenderer artifacts are ~2 years behind the FB version. Fabric host components store internal instance in __internalInstanceHandle field, previously they have been storing it in the field with the same name, but with one underscore in prefix: https://www.internalfb.com/code/fbsource/[79c52d10beb6]/xplat/js/react-native-github/packages/react-native/Libraries/Renderer/implementations/ReactFabric-dev.js?lines=5151 Once these artifacts will be synced, the implementation will use __internalInstanceHandle field, so we can safely remove the branch with a single underscore prefix. Reviewed By: rubennorte Differential Revision: D52697886
…2285) Summary: Changelog: [Internal] Having a static import of `ReactFabric` blocks from using `ReactNativeElement` class for Paper-only applications. Although DOM Node APIs are Fabric-only, the ability to use `instanceof ReactNativeElement` is a nice tool for gating purposes, which currently can't be used because of the static import. Reviewed By: rubennorte Differential Revision: D52784886
…ompatible with previous Fabric implementation (facebook#42250) Summary: Changelog: [Internal] Currently, OSS versions ofReactFabric and ReactNativeRenderer artifacts are ~2 years behind the FB version. Fabric host components store internal instance in __internalInstanceHandle field, previously they have been storing it in the field with the same name, but with one underscore in prefix: https://www.internalfb.com/code/fbsource/[79c52d10beb6]/xplat/js/react-native-github/packages/react-native/Libraries/Renderer/implementations/ReactFabric-dev.js?lines=5151 Once these artifacts will be synced, the implementation will use __internalInstanceHandle field, so we can safely remove the branch with a single underscore prefix. Reviewed By: rubennorte Differential Revision: D52697886
hoxyq
force-pushed
the
export-D52697886
branch
from
c56a41f to
3c116a7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52697886 |
|
This pull request has been merged in c393f7a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Currently, OSS versions ofReactFabric and ReactNativeRenderer artifacts are ~2 years behind the FB version.
Fabric host components store internal instance in __internalInstanceHandle field, previously they have been storing it in the field with the same name, but with one underscore in prefix:
https://www.internalfb.com/code/fbsource/[79c52d10beb6]/xplat/js/react-native-github/packages/react-native/Libraries/Renderer/implementations/ReactFabric-dev.js?lines=5151
Once these artifacts will be synced, the implementation will use __internalInstanceHandle field, so we can safely remove the branch with a single underscore prefix.
Differential Revision: D52697886