Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert DefaultComponentsRegistry::registerComponentDescriptorsFromEntryPoint is set #42312

Closed
wants to merge 2 commits into from
Closed

Assert DefaultComponentsRegistry::registerComponentDescriptorsFromEntryPoint is set #42312

wants to merge 2 commits into from

Conversation

tido64
Copy link
Collaborator

@tido64 tido64 commented Jan 16, 2024

Summary:

Assert DefaultComponentsRegistry::registerComponentDescriptorsFromEntryPoint is set. For full context, see #42244.

Changelog:

[ANDROID] [FIXED] - Assert DefaultComponentsRegistry::registerComponentDescriptorsFromEntryPoint is set

Test Plan:

n/a

@tido64 tido64 requested a review from cortinico January 16, 2024 19:32
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 16, 2024
@cortinico
Copy link
Contributor

Thanks for sending this btw @tido64 🙏

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,809,116 +10,123
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,200,490 +10,178
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: a5fbe28
Branch: main

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 18, 2024
@facebook-github-bot
Copy link
Contributor

@cortinico merged this pull request in 8474e23.

@tido64 tido64 deleted the tido/assert-registerComponentDescriptorsFromEntryPoint branch January 18, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tido64 @cortinico @analysis-bot @facebook-github-bot