Fix RemoveDeleteTree and subview clipping compatibility #42355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52834835 |
Base commit: 31a162f |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 18, 2024
Summary: `RemoveDeleteTreeUIFrameCallback` operated directly on the view to clean up its children, which does not correctly account for subviews which have been clipped because they're outside the visible frame. Changelog: [Android][Added] Added `removeAllViews` to IViewGroupManager. Reviewed By: jehartzog, sammy-SC Differential Revision: D52834835
javache
force-pushed
the
export-D52834835
branch
from
452b248 to
6034d78
Compare
Summary: `RemoveDeleteTreeUIFrameCallback` operated directly on the view to clean up its children, which does not correctly account for subviews which have been clipped because they're outside the visible frame. Changelog: [Android][Added] Added `removeAllViews` to IViewGroupManager. Reviewed By: jehartzog, sammy-SC Differential Revision: D52834835
|
This pull request was exported from Phabricator. Differential Revision: D52834835 |
javache
force-pushed
the
export-D52834835
branch
from
6034d78 to
a966e16
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52834835 |
|
This pull request has been merged in 3cd85dc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
RemoveDeleteTreeUIFrameCallbackoperated directly on the view to clean up its children, which does not correctly account for subviews which have been clipped because they're outside the visible frame.Changelog: [Android][Added] Added
removeAllViewsto IViewGroupManager.Reviewed By: jehartzog, sammy-SC
Differential Revision: D52834835