Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ineffective excludes from typescript-config #42375

Closed

Conversation

friederbluemle
Copy link
Contributor

Summary:

This removes the 4 ineffective and redundant entries from the exclude list in tsconfig.json (typescript-config package).

These entries have no effect as they are relative to the typescript-config package. Explained in detail here: tsconfig/bases#207

A newly generated RN app shows this config:

$ yarn tsc --showConfig | grep -A 5 exclude
    "exclude": [
        "node_modules/@tsconfig/react-native/node_modules",
        "node_modules/@tsconfig/react-native/babel.config.js",
        "node_modules/@tsconfig/react-native/metro.config.js",
        "node_modules/@tsconfig/react-native/jest.config.js"
    ]

Clearly, none of these files exist, therefore to remove ambiguity and reduce the complexity of the config, they should be removed.

Changelog:

[GENERAL] [REMOVED] - Remove ineffective excludes from typescript-config

Test Plan:

  • Create new RN app (npx react-native init), install dependencies, run yarn tsc
  • It works
  • Recreate config, but without the exclude section
  • Everything works exactly the same

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 19, 2024
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,794,862 -1
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,186,208 +6
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: c33ac4b
Branch: main

@facebook-github-bot
Copy link
Contributor

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 19, 2024
@facebook-github-bot
Copy link
Contributor

@NickGerleman merged this pull request in b962197.

@friederbluemle friederbluemle deleted the update-ts-config branch January 19, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants