Move DOM APIs to private directory #42386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52875998 |
Base commit: a758694 |
|
This pull request was exported from Phabricator. Differential Revision: D52875998 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 19, 2024
Summary: Pull Request resolved: facebook#42386 The new DOM APIs are completely private at the moment, so they make them a good candidate to test the new directory structure (and make sure everything works correctly in CI, etc.). This moves those files to `src/private/dom`. Changelog: [internal] Reviewed By: huntie Differential Revision: D52875998 fbshipit-source-id: 848510d3fd63cd8daed7225e6b7effb5afb8191e
rubennorte
force-pushed
the
export-D52875998
branch
from
0f8dcb2 to
6db5f9a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52875998 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 19, 2024
Summary: Pull Request resolved: facebook#42386 The new DOM APIs are completely private at the moment, so they make them a good candidate to test the new directory structure (and make sure everything works correctly in CI, etc.). This moves those files to `src/private/dom`. Changelog: [internal] Reviewed By: huntie Differential Revision: D52875998 fbshipit-source-id: c816abc75e48eeca806298ac4bf66750e037c69d
rubennorte
force-pushed
the
export-D52875998
branch
from
6db5f9a to
bf10fa3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52875998 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 19, 2024
Summary: Pull Request resolved: facebook#42386 The new DOM APIs are completely private at the moment, so they make them a good candidate to test the new directory structure (and make sure everything works correctly in CI, etc.). This moves those files to `src/private/dom`. Changelog: [internal] Reviewed By: huntie Differential Revision: D52875998 fbshipit-source-id: aebdaf2bb84370a052ca5a5133ea683eb3bd36e0
rubennorte
force-pushed
the
export-D52875998
branch
from
bf10fa3 to
cb20504
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52875998 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 19, 2024
Summary: Pull Request resolved: facebook#42386 The new DOM APIs are completely private at the moment, so they make them a good candidate to test the new directory structure (and make sure everything works correctly in CI, etc.). This moves those files to `src/private/dom`. Changelog: [internal] Reviewed By: huntie Differential Revision: D52875998 fbshipit-source-id: 955355b7b36689496c2ca8fc23f2f1160e99ed70
rubennorte
force-pushed
the
export-D52875998
branch
from
cb20504 to
fc9d565
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52875998 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 19, 2024
Summary: Pull Request resolved: facebook#42386 The new DOM APIs are completely private at the moment, so they make them a good candidate to test the new directory structure (and make sure everything works correctly in CI, etc.). This moves those files to `src/private/dom`. Changelog: [internal] Reviewed By: huntie Differential Revision: D52875998 fbshipit-source-id: 759c2c83528e0f6aa8e94886dd8966ba2da05885
rubennorte
force-pushed
the
export-D52875998
branch
from
fc9d565 to
5d882d7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52875998 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 19, 2024
Summary: Pull Request resolved: facebook#42386 The new DOM APIs are completely private at the moment, so they make them a good candidate to test the new directory structure (and make sure everything works correctly in CI, etc.). This moves those files to . Changelog: [internal] Reviewed By: huntie Differential Revision: D52875998 fbshipit-source-id: 7251aca6e4a8af351ad9dcba0cfc6b5189e514cb
rubennorte
force-pushed
the
export-D52875998
branch
from
5d882d7 to
a299ebd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52875998 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 19, 2024
Summary: Pull Request resolved: facebook#42386 The new DOM APIs are completely private at the moment, so they make them a good candidate to test the new directory structure (and make sure everything works correctly in CI, etc.). This moves those files to . Changelog: [internal] Reviewed By: huntie Differential Revision: D52875998 fbshipit-source-id: df5c2ab3653307a971d683d8b0a2634a51d80d46
rubennorte
force-pushed
the
export-D52875998
branch
from
a299ebd to
082df0b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52875998 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 19, 2024
Summary: Pull Request resolved: facebook#42386 The new DOM APIs are completely private at the moment, so they make them a good candidate to test the new directory structure (and make sure everything works correctly in CI, etc.). This moves those files to . Changelog: [internal] Reviewed By: huntie Differential Revision: D52875998 fbshipit-source-id: 01bd5cb7452b2aca19affa9e0049f8625912e0bc
rubennorte
force-pushed
the
export-D52875998
branch
from
082df0b to
83c728c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52875998 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 21, 2024
Summary: Pull Request resolved: facebook#42386 The new DOM APIs are completely private at the moment, so they make them a good candidate to test the new directory structure (and make sure everything works correctly in CI, etc.). This moves those files to . Changelog: [internal] Reviewed By: huntie Differential Revision: D52875998 fbshipit-source-id: 265e40e92c74ad2d1dcc05e33fd084e907109f05
rubennorte
force-pushed
the
export-D52875998
branch
from
8920ada to
2158a14
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52875998 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 21, 2024
Summary: Pull Request resolved: facebook#42386 The new DOM APIs are completely private at the moment, so they make them a good candidate to test the new directory structure (and make sure everything works correctly in CI, etc.). This moves those files to `src/private/dom`. Changelog: [internal] Reviewed By: huntie Differential Revision: D52875998 fbshipit-source-id: f6d861a4df0d389b99c0667da5ec82ac96531b38
rubennorte
force-pushed
the
export-D52875998
branch
from
2158a14 to
0a26d66
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52875998 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 21, 2024
Summary: Pull Request resolved: facebook#42386 The new DOM APIs are completely private at the moment, so they make them a good candidate to test the new directory structure (and make sure everything works correctly in CI, etc.). This moves those files to . Changelog: [internal] Reviewed By: huntie Differential Revision: D52875998 fbshipit-source-id: 46048cc5ed0d598a7e35dfaf84f9c98ce4a1ce35
rubennorte
force-pushed
the
export-D52875998
branch
from
0a26d66 to
d39b918
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52875998 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 21, 2024
Summary: Pull Request resolved: facebook#42386 The new DOM APIs are completely private at the moment, so they make them a good candidate to test the new directory structure (and make sure everything works correctly in CI, etc.). This moves those files to . Changelog: [internal] Reviewed By: huntie Differential Revision: D52875998 fbshipit-source-id: d5aa49bc67498f4d1e5cf2c27f8e040844801cfc
rubennorte
force-pushed
the
export-D52875998
branch
from
d39b918 to
f5a5057
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52875998 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 21, 2024
Summary: Pull Request resolved: facebook#42386 The new DOM APIs are completely private at the moment, so they make them a good candidate to test the new directory structure (and make sure everything works correctly in CI, etc.). This moves those files to . Changelog: [internal] Reviewed By: huntie Differential Revision: D52875998 fbshipit-source-id: 654912c44616338cfafbdcf9ab9c9442559d903a
rubennorte
force-pushed
the
export-D52875998
branch
from
f5a5057 to
ac5ff2f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52875998 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 21, 2024
Summary: Pull Request resolved: facebook#42386 The new DOM APIs are completely private at the moment, so they make them a good candidate to test the new directory structure (and make sure everything works correctly in CI, etc.). This moves those files to `src/private/dom`. Changelog: [internal] Reviewed By: huntie Differential Revision: D52875998 fbshipit-source-id: d4a66359a895cde555bc68dbf1265a89e7edaad0
rubennorte
force-pushed
the
export-D52875998
branch
from
ac5ff2f to
a5e13af
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 21, 2024
Summary: Pull Request resolved: facebook#42386 The new DOM APIs are completely private at the moment, so they make them a good candidate to test the new directory structure (and make sure everything works correctly in CI, etc.). This moves those files to `src/private/dom`. Changelog: [internal] Reviewed By: huntie Differential Revision: D52875998 fbshipit-source-id: f1e683a1c7248c93e7011426fb0165fd045abff9
Summary: Pull Request resolved: facebook#42385 This adds support for having JS files in a `src` directory within the `react-native` package. The plan is to have 2 subdirectories there: * `react-native/src/private` for private modules, with any nested directories (e.g.: `react-native/src/private/dom/nodes/ReadOnlyNode.js`). * `react-native/src/public` for public modules, without nested directories. The plan is that the individual modules created in this directory will be public through the index module or directly via something like `react-native/View` (mapped to `react-native/src/public/View`, or a `dist` directory in the published npm package—details TBD). The enforcement of private modules being inaccessible from outside the `react-native` package will be added soon by huntie. Changelog: [internal] Reviewed By: huntie Differential Revision: D52875999 fbshipit-source-id: 425126644258987f58e249b67a7da0c625e48bad
Summary: Pull Request resolved: facebook#42386 The new DOM APIs are completely private at the moment, so they make them a good candidate to test the new directory structure (and make sure everything works correctly in CI, etc.). This moves those files to `src/private/dom`. Changelog: [internal] Reviewed By: huntie Differential Revision: D52875998 fbshipit-source-id: ae2910edfde601fceb2eba1445a9695c2e4b70d6
|
This pull request was exported from Phabricator. Differential Revision: D52875998 |
rubennorte
force-pushed
the
export-D52875998
branch
from
a5e13af to
e8bf94b
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 22, 2024
Summary: Pull Request resolved: facebook#42386 The new DOM APIs are completely private at the moment, so they make them a good candidate to test the new directory structure (and make sure everything works correctly in CI, etc.). This moves those files to `src/private/dom`. Changelog: [internal] Reviewed By: huntie Differential Revision: D52875998 fbshipit-source-id: 945e80739b3afa535079ef24e6802f4d7780b565
|
This pull request has been merged in 1d3349e. |
|
This pull request has been reverted by 7475e2b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The new DOM APIs are completely private at the moment, so they make them a good candidate to test the new directory structure (and make sure everything works correctly in CI, etc.). This moves those files to
src/private/dom.Changelog: [internal]
Reviewed By: huntie
Differential Revision: D52875998