Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN] Move feature flags for the event loop to ReactNativeFeatureFlags #42434

Closed
wants to merge 2 commits into from

Conversation

rubennorte
Copy link
Contributor

Summary: Changelog: [internal]

Differential Revision: D52819137

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jan 20, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52819137

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52819137

rubennorte added a commit to rubennorte/react-native that referenced this pull request Jan 20, 2024
…eatureFlags (facebook#42434)

Summary:
Pull Request resolved: facebook#42434

Changelog: [internal]

Differential Revision: D52819137

fbshipit-source-id: c8ea72a71bd0fb0074416d7aa81f81a6e3d738ba
@rubennorte rubennorte changed the title '[skip ci] [RN] Move feature flags for the event loop to ReactNativeFeatureFlags [RN] Move feature flags for the event loop to ReactNativeFeatureFlags Jan 20, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52819137

rubennorte added a commit to rubennorte/react-native that referenced this pull request Jan 20, 2024
…eatureFlags (facebook#42434)

Summary:
Pull Request resolved: facebook#42434

Changelog: [internal]

Differential Revision: D52819137

fbshipit-source-id: fa8a29c7342217fcf9a5df4429915152afb4cb5f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52819137

rubennorte added a commit to rubennorte/react-native that referenced this pull request Jan 20, 2024
…eatureFlags (facebook#42434)

Summary:
Pull Request resolved: facebook#42434

Changelog: [internal]

Differential Revision: D52819137

fbshipit-source-id: 09b597612171d63d0afbecd637a42299e0fc8414
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52819137

rubennorte added a commit to rubennorte/react-native that referenced this pull request Jan 20, 2024
…eatureFlags (facebook#42434)

Summary:
Pull Request resolved: facebook#42434

Changelog: [internal]

Differential Revision: D52819137

fbshipit-source-id: beb879008b89cefb16d2e0af04d6fecd20d8b26c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52819137

rubennorte added a commit to rubennorte/react-native that referenced this pull request Jan 20, 2024
…eatureFlags (facebook#42434)

Summary:
Pull Request resolved: facebook#42434

Changelog: [internal]

Differential Revision: D52819137

fbshipit-source-id: d3167472431eaf7316a2219d4fd53daa623feea9
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52819137

rubennorte added a commit to rubennorte/react-native that referenced this pull request Jan 20, 2024
…eatureFlags (facebook#42434)

Summary:
Pull Request resolved: facebook#42434

Changelog: [internal]

Differential Revision: D52819137

fbshipit-source-id: d78449bba54b4c549700be4c733543dbf745e15f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52819137

rubennorte added a commit to rubennorte/react-native that referenced this pull request Jan 21, 2024
…eatureFlags (facebook#42434)

Summary:
Pull Request resolved: facebook#42434

Changelog: [internal]

Differential Revision: D52819137

fbshipit-source-id: b689361856cb46ad5c6c8440b1d582c59c13a9c6
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52819137

rubennorte added a commit to rubennorte/react-native that referenced this pull request Jan 21, 2024
…eatureFlags (facebook#42434)

Summary:
Pull Request resolved: facebook#42434

Changelog: [internal]

Differential Revision: D52819137

fbshipit-source-id: 9fb31c706f512c2f8a57f76ff813879363603efc
rubennorte added a commit to rubennorte/react-native that referenced this pull request Jan 25, 2024
…ebook#42434)

Summary:
Pull Request resolved: facebook#42434

Changelog: [internal]

The flags for the event loop were set up using different mechanisms due to the limitations of the previous feature flags systems. Now we can centralize on the new system and use them consistently on Android and iOS.

Reviewed By: RSNara

Differential Revision: D52819137

fbshipit-source-id: 345d9133f2137fa44b0fd0f258cfae2c891e3417
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52819137

rubennorte added a commit to rubennorte/react-native that referenced this pull request Jan 25, 2024
…ebook#42434)

Summary:
Pull Request resolved: facebook#42434

Changelog: [internal]

The flags for the event loop were set up using different mechanisms due to the limitations of the previous feature flags systems. Now we can centralize on the new system and use them consistently on Android and iOS.

Reviewed By: RSNara

Differential Revision: D52819137

fbshipit-source-id: 63c9a80dabd59b71f07fb180aa5bd048c8b124fd
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52819137

rubennorte added a commit to rubennorte/react-native that referenced this pull request Jan 25, 2024
…ebook#42434)

Summary:
Pull Request resolved: facebook#42434

Changelog: [internal]

The flags for the event loop were set up using different mechanisms due to the limitations of the previous feature flags systems. Now we can centralize on the new system and use them consistently on Android and iOS.

Reviewed By: RSNara

Differential Revision: D52819137

fbshipit-source-id: 29fa849ca7608b6e52d48614ca9d1e2ece403261
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52819137

rubennorte added a commit to rubennorte/react-native that referenced this pull request Jan 25, 2024
…ebook#42434)

Summary:
Pull Request resolved: facebook#42434

Changelog: [internal]

The flags for the event loop were set up using different mechanisms due to the limitations of the previous feature flags systems. Now we can centralize on the new system and use them consistently on Android and iOS.

Reviewed By: RSNara

Differential Revision: D52819137

fbshipit-source-id: 37f902ffa97616a4995706e3bdf2d19ea25d9afd
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52819137

rubennorte added a commit to rubennorte/react-native that referenced this pull request Jan 25, 2024
…ebook#42434)

Summary:
Pull Request resolved: facebook#42434

Changelog: [internal]

The flags for the event loop were set up using different mechanisms due to the limitations of the previous feature flags systems. Now we can centralize on the new system and use them consistently on Android and iOS.

Reviewed By: RSNara

Differential Revision: D52819137

fbshipit-source-id: d14d419475282be653e5dad7c27d2125be04d7dd
rubennorte and others added 2 commits January 25, 2024 07:15
Differential Revision: D52806730

fbshipit-source-id: a5026941589ae3e222d49cc803e4b88d037f9db0
…ebook#42434)

Summary:
Pull Request resolved: facebook#42434

Changelog: [internal]

The flags for the event loop were set up using different mechanisms due to the limitations of the previous feature flags systems. Now we can centralize on the new system and use them consistently on Android and iOS.

Reviewed By: RSNara

Differential Revision: D52819137

fbshipit-source-id: 1e89ae554f7668ed6e4e9143e6e9690982388315
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52819137

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in e04d1b4.

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 31a8bc9.

rubennorte added a commit to rubennorte/react-native that referenced this pull request Jan 26, 2024
…land)

Summary:
Changelog: [internal]

This is a re-application of facebook#42434 which had to be reverted after a problem in a previous PR.

See details in the original PR.

Differential Revision: D53122991

fbshipit-source-id: d87cd152ab86be8428eac348eb86f95c1485270f
rubennorte added a commit to rubennorte/react-native that referenced this pull request Jan 26, 2024
…land) (facebook#42677)

Summary:
Pull Request resolved: facebook#42677

Changelog: [internal]

This is a re-application of facebook#42434 which had to be reverted after a problem in a previous PR.

See details in the original PR.

Reviewed By: huntie

Differential Revision: D53122991

fbshipit-source-id: bb05f0868ec044eca9f4951a2e8233231a5e2235
rubennorte added a commit to rubennorte/react-native that referenced this pull request Jan 26, 2024
…land) (facebook#42677)

Summary:
Pull Request resolved: facebook#42677

Changelog: [internal]

This is a re-application of facebook#42434 which had to be reverted after a problem in a previous PR.

See details in the original PR.

Reviewed By: huntie

Differential Revision: D53122991

fbshipit-source-id: 56a762f450b6ccd5a9a3bd364954ef9698d062c4
rubennorte added a commit to rubennorte/react-native that referenced this pull request Jan 26, 2024
…land) (facebook#42677)

Summary:
Pull Request resolved: facebook#42677

Changelog: [internal]

This is a re-application of facebook#42434 which had to be reverted after a problem in a previous PR.

See details in the original PR.

Reviewed By: huntie

Differential Revision: D53122991

fbshipit-source-id: da33fdb51e848c5319adafbcda323d19c946069f
facebook-github-bot pushed a commit that referenced this pull request Jan 26, 2024
…land) (#42677)

Summary:
Pull Request resolved: #42677

Changelog: [internal]

This is a re-application of #42434 which had to be reverted after a problem in a previous PR.

See details in the original PR.

Reviewed By: huntie

Differential Revision: D53122991

fbshipit-source-id: 5bc4306522fc5fa48ea81d0802d0f891706cfbf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Reverted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants