Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: UpdatePropertiesExampleView mutate existing appProperties instead of overwriting #42634

Closed
wants to merge 1 commit into from
Closed

fix: UpdatePropertiesExampleView mutate existing appProperties instead of overwriting #42634

wants to merge 1 commit into from

Conversation

okwasniewski
Copy link
Contributor

@okwasniewski okwasniewski commented Jan 24, 2024 •
edited
Loading

Summary:

For Bridgeless mode we set fabric and concurrentRoot property for newly initialized views. This example overwrites those properties. I think we should Instead copy previous dictionary and only overwrite color key.

This issue results in a warning: "Using Fabric without concurrent root is deprecated. Please enable concurrent root for this application."

Note: This Example crashes on Bridgeless but my other PR #42263 fixes it.

Changelog:

[INTERNAL] [FIXED] - UpdatePropertiesExampleView to mutate existing appProperties instead of overwriting

Test Plan:

  1. Wait for this example to get fixed for Bridgeless
  2. Click the button to update props
  3. Check if there is no warning

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 24, 2024
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,951,813 -20,476
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,335,591 -20,495
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: d46d80d
Branch: main

@mdvacca
Copy link
Contributor

mdvacca commented Jan 25, 2024

@cipolleschi could you review this PR?

cipolleschi
cipolleschi approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @okwasniewski thanks for fixing this!

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 7, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in c1b8f37.

@okwasniewski okwasniewski deleted the fix/bridgeless-updateproperties branch February 7, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@okwasniewski @analysis-bot @mdvacca @facebook-github-bot @cipolleschi