Improve types, fix translator compatibility for version-related modules #42638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52963967 |
Base commit: 631b6a1 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jan 24, 2024
…es (facebook#42638) Summary: Enables these modules to be covered by `public-api-test`. - Standardise as CommonJS modules, fixing compatibility with [`flow-api-translator`](https://www.npmjs.com/package/flow-api-translator). - Use explicit object type in generated file template. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52963967
huntie
force-pushed
the
export-D52963967
branch
from
f528523 to
5cd99be
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52963967 |
…es (facebook#42638) Summary: Enables these modules to be covered by `public-api-test`. - Standardise as CommonJS modules, fixing compatibility with [`flow-api-translator`](https://www.npmjs.com/package/flow-api-translator). - Use explicit object type in generated file template. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52963967
huntie
force-pushed
the
export-D52963967
branch
from
5cd99be to
f52823f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52963967 |
|
This pull request has been merged in 02e7244. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enables these modules to be covered by
public-api-test.flow-api-translator.Changelog: [Internal]
Reviewed By: NickGerleman
Differential Revision: D52963967