Cleanup srcSet for java and res #42659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53083677 |
Base commit: 889ead1 |
Summary: Those folders for Java don't exist anymore, I'm removing this as it's unnecessary and will default to only src/main/java. For resources instead, I'm using `setSrcDirs` as it will replace the default, while `srcDirs()` will add those folders. We need to replace the default res folder as we need to follow the resource folder structure of BUCK Changelog: [Internal] [Changed] - Cleanup srcSet for java and res Reviewed By: cipolleschi Differential Revision: D53083677
cortinico
force-pushed
the
export-D53083677
branch
from
f8986b1
to
a1696db
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53083677 |
|
This pull request has been merged in 97d6d72. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Those folders for Java don't exist anymore, I'm removing this as it's unnecessary and will default to only src/main/java.
For resources instead, I'm using
setSrcDirsas it will replace the default, whilesrcDirs()will add those folders.We need to replace the default res folder as we need to follow the resource folder structure of BUCK
Changelog:
[Internal] [Changed] - Cleanup srcSet for java and res
Differential Revision: D53083677