Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Flow in feature flags scripts #42814

Closed
wants to merge 2 commits into from

Conversation

rubennorte
Copy link
Contributor

Summary:
Improves the type safety of the feature flags generation and verification script.

Changelog: [internal]

Differential Revision: D53351484

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Feb 2, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53351484

rubennorte added a commit to rubennorte/react-native that referenced this pull request Feb 2, 2024
Summary:

Improves the type safety of the feature flags generation and verification script.

Changelog: [internal]

Differential Revision: D53351484
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53351484

@analysis-bot
Copy link

analysis-bot commented Feb 2, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,229,284 +6
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,596,087 -6
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 48a19d7
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53351484

rubennorte added a commit to rubennorte/react-native that referenced this pull request Feb 5, 2024
Summary:
Pull Request resolved: facebook#42814

Improves the type safety of the feature flags generation and verification script.

Changelog: [internal]

Reviewed By: huntie

Differential Revision: D53351484

fbshipit-source-id: 22a30d86726ca55d7e477d87377ac4ccb9dc39c8
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53351484

rubennorte added a commit to rubennorte/react-native that referenced this pull request Feb 5, 2024
Summary:
Pull Request resolved: facebook#42814

Improves the type safety of the feature flags generation and verification script.

Changelog: [internal]

Reviewed By: huntie

Differential Revision: D53351484

fbshipit-source-id: 3cc437aa091d54a72f736bc0e63e176b7690e461
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53351484

rubennorte added a commit to rubennorte/react-native that referenced this pull request Feb 5, 2024
Summary:
Pull Request resolved: facebook#42814

Improves the type safety of the feature flags generation and verification script.

Changelog: [internal]

Reviewed By: huntie

Differential Revision: D53351484

fbshipit-source-id: 526881ac5c37e5785c335742482632a47c0ba162
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53351484

rubennorte added a commit to rubennorte/react-native that referenced this pull request Feb 5, 2024
Summary:
Pull Request resolved: facebook#42814

Improves the type safety of the feature flags generation and verification script.

Changelog: [internal]

Reviewed By: huntie

Differential Revision: D53351484

fbshipit-source-id: b6ca64638c3665e40184bd491cc1b1721670b2e6
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53351484

rubennorte added a commit to rubennorte/react-native that referenced this pull request Feb 5, 2024
Summary:
Pull Request resolved: facebook#42814

Improves the type safety of the feature flags generation and verification script.

Changelog: [internal]

Reviewed By: huntie

Differential Revision: D53351484

fbshipit-source-id: fd2a4a58da89c6fad508f9c9a015c9d492dbb3d4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53351484

rubennorte added a commit to rubennorte/react-native that referenced this pull request Feb 5, 2024
Summary:
Pull Request resolved: facebook#42814

Improves the type safety of the feature flags generation and verification script.

Changelog: [internal]

bypass github-export-checks
(CI is broken on main)

Reviewed By: huntie

Differential Revision: D53351484

fbshipit-source-id: 0ecb0b58ae3fce400b616c5d9847f573a6240397
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53351484

rubennorte added a commit to rubennorte/react-native that referenced this pull request Feb 5, 2024
Summary:
Pull Request resolved: facebook#42814

Improves the type safety of the feature flags generation and verification script.

Changelog: [internal]

bypass-github-export-checks
(CI is broken on main)

Reviewed By: huntie

Differential Revision: D53351484

fbshipit-source-id: c4abfcb9d0433fbd6917e9fc134eec4bcb2f4056
rubennorte and others added 2 commits February 5, 2024 09:55
Differential Revision: D53416934

fbshipit-source-id: 15d51c5df284dda1ef7a55e8b4af254080a30fdf
Summary:
Pull Request resolved: facebook#42814

Improves the type safety of the feature flags generation and verification script.

Changelog: [internal]

bypass-github-export-checks
(CI is broken on main)

Reviewed By: huntie

Differential Revision: D53351484

fbshipit-source-id: 6e290e8676718569ce177a61e4d5223afc3e5c7a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53351484

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 5, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in dbbec34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants