Improve CDP Flow types #42816
Closed
Improve CDP Flow types #42816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53352243 |
Summary: Some refactoring to formalise CDP protocol types (`protocol.js` is aligned with [Chrome's `protocol.d.ts` source](https://github.com/ChromeDevTools/devtools-protocol/blob/master/types/protocol.d.ts)), and to demarcate these from other types in the Inspector Proxy prototol. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D53352243
huntie
force-pushed
the
export-D53352243
branch
from
ffeb912 to
d325e19
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53352243 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 6, 2024
Summary: Some refactoring to formalise CDP protocol types (`protocol.js` is aligned with [Chrome's `protocol.d.ts` source](https://github.com/ChromeDevTools/devtools-protocol/blob/master/types/protocol.d.ts)), and to demarcate these from other types in the Inspector Proxy prototol. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D53352243
|
This pull request has been merged in 1429378. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Some refactoring to formalise CDP protocol types (
protocol.jsis aligned with Chrome'sprotocol.d.tssource), and to demarcate these from other types in the Inspector Proxy prototol.Changelog: [Internal]
Differential Revision: D53352243