Add runtime check to ensure feature flags are only overridden once #42825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
Base commit: e350859 |
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 5, 2024
…acebook#42825) Summary: Pull Request resolved: facebook#42825 This makes overrides for feature flags more predictable by only allowing a single point of overrides per app. The previous behavior was: * Common flags: the last override would win. * JS flags: overrides would be combined and the last definition for each flag would win. The new behavior, both for common flags and for JS flags, is to only have a single override. Changelog: [internal] Reviewed By: mdvacca Differential Revision: D53360609 fbshipit-source-id: ed225f16f4977ce0518ae058b3a46df147dec96b
rubennorte
force-pushed
the
export-D53360609
branch
from
d698975 to
c70ebc5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 5, 2024
…acebook#42825) Summary: Pull Request resolved: facebook#42825 This makes overrides for feature flags more predictable by only allowing a single point of overrides per app. The previous behavior was: * Common flags: the last override would win. * JS flags: overrides would be combined and the last definition for each flag would win. The new behavior, both for common flags and for JS flags, is to only have a single override. Changelog: [internal] Reviewed By: mdvacca Differential Revision: D53360609 fbshipit-source-id: cec84c850c61b8e5fb44b9a4edad25a2874bf8f9
rubennorte
force-pushed
the
export-D53360609
branch
from
c70ebc5 to
9dfdd3a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 5, 2024
…acebook#42825) Summary: Pull Request resolved: facebook#42825 This makes overrides for feature flags more predictable by only allowing a single point of overrides per app. The previous behavior was: * Common flags: the last override would win. * JS flags: overrides would be combined and the last definition for each flag would win. The new behavior, both for common flags and for JS flags, is to only have a single override. Changelog: [internal] Reviewed By: mdvacca Differential Revision: D53360609 fbshipit-source-id: f452c4263a2ac6192e90b2a43b620fdeb1bba51f
rubennorte
force-pushed
the
export-D53360609
branch
from
9dfdd3a to
b680b05
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 5, 2024
…acebook#42825) Summary: Pull Request resolved: facebook#42825 This makes overrides for feature flags more predictable by only allowing a single point of overrides per app. The previous behavior was: * Common flags: the last override would win. * JS flags: overrides would be combined and the last definition for each flag would win. The new behavior, both for common flags and for JS flags, is to only have a single override. Changelog: [internal] Reviewed By: mdvacca Differential Revision: D53360609 fbshipit-source-id: 03d58eb43b5b9988b68337ea5828ba284d86cbd1
rubennorte
force-pushed
the
export-D53360609
branch
from
b680b05 to
2ddef58
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 5, 2024
…acebook#42825) Summary: Pull Request resolved: facebook#42825 This makes overrides for feature flags more predictable by only allowing a single point of overrides per app. The previous behavior was: * Common flags: the last override would win. * JS flags: overrides would be combined and the last definition for each flag would win. The new behavior, both for common flags and for JS flags, is to only have a single override. Changelog: [internal] Reviewed By: mdvacca Differential Revision: D53360609 fbshipit-source-id: 2135109c68d73fa0bb73ac8d71e8ba6641b0a9eb
rubennorte
force-pushed
the
export-D53360609
branch
from
2ddef58 to
a46e782
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 5, 2024
…acebook#42825) Summary: Pull Request resolved: facebook#42825 This makes overrides for feature flags more predictable by only allowing a single point of overrides per app. The previous behavior was: * Common flags: the last override would win. * JS flags: overrides would be combined and the last definition for each flag would win. The new behavior, both for common flags and for JS flags, is to only have a single override. Changelog: [internal] bypass github-export-checks Reviewed By: mdvacca Differential Revision: D53360609 fbshipit-source-id: 73c901a73daf2924e821b3be288e381f1d0dc002
rubennorte
force-pushed
the
export-D53360609
branch
from
a46e782 to
89347a8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 5, 2024
…acebook#42825) Summary: Pull Request resolved: facebook#42825 This makes overrides for feature flags more predictable by only allowing a single point of overrides per app. The previous behavior was: * Common flags: the last override would win. * JS flags: overrides would be combined and the last definition for each flag would win. The new behavior, both for common flags and for JS flags, is to only have a single override. Changelog: [internal] bypass-github-export-checks (CI is broken on main) Reviewed By: mdvacca Differential Revision: D53360609 fbshipit-source-id: 5474213224cf0eaf43b0e702dd94fe688ce212e9
rubennorte
force-pushed
the
export-D53360609
branch
from
89347a8 to
7007fd9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 5, 2024
…acebook#42825) Summary: Pull Request resolved: facebook#42825 This makes overrides for feature flags more predictable by only allowing a single point of overrides per app. The previous behavior was: * Common flags: the last override would win. * JS flags: overrides would be combined and the last definition for each flag would win. The new behavior, both for common flags and for JS flags, is to only have a single override. Changelog: [internal] bypass-github-export-checks (CI is broken on main) Reviewed By: mdvacca Differential Revision: D53360609 fbshipit-source-id: b3f7775d834f430a162224081c3dadbd70902ad1
rubennorte
force-pushed
the
export-D53360609
branch
from
7007fd9 to
719c94a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 5, 2024
…acebook#42825) Summary: Pull Request resolved: facebook#42825 This makes overrides for feature flags more predictable by only allowing a single point of overrides per app. The previous behavior was: * Common flags: the last override would win. * JS flags: overrides would be combined and the last definition for each flag would win. The new behavior, both for common flags and for JS flags, is to only have a single override. Changelog: [internal] bypass-github-export-checks (CI is broken on main) Reviewed By: mdvacca Differential Revision: D53360609 fbshipit-source-id: 46e1494670f69205c28b291e6bd21a45026017df
rubennorte
force-pushed
the
export-D53360609
branch
from
719c94a to
be1b2c4
Compare
Differential Revision: D53416934 fbshipit-source-id: 0ebfa8cdcbf989aefc9dc679a381d85e53b59a3e
Differential Revision: D53351484 fbshipit-source-id: 0e647c6b67d6c5b2ed5802683d6b43691ec96fb4
Differential Revision: D53351483 fbshipit-source-id: eaa22ba078723ec21dcf30465fb23c91c8139420
Differential Revision: D53352391 fbshipit-source-id: 21ffc65c4a91854a05f2af70b2c2b33eed899880
…acebook#42825) Summary: Pull Request resolved: facebook#42825 This makes overrides for feature flags more predictable by only allowing a single point of overrides per app. The previous behavior was: * Common flags: the last override would win. * JS flags: overrides would be combined and the last definition for each flag would win. The new behavior, both for common flags and for JS flags, is to only have a single override. Changelog: [internal] bypass-github-export-checks (CI is broken on main) Reviewed By: mdvacca Differential Revision: D53360609 fbshipit-source-id: ff987cd323800a3786101a31b4dd3dc27294ce77
|
This pull request was exported from Phabricator. Differential Revision: D53360609 |
rubennorte
force-pushed
the
export-D53360609
branch
from
be1b2c4 to
47f9235
Compare
|
This pull request has been merged in fd6a6fe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This makes overrides for feature flags more predictable by only allowing a single point of overrides per app.
The previous behavior was:
The new behavior, both for common flags and for JS flags, is to only have a single override.
Changelog: [internal]
Reviewed By: mdvacca
Differential Revision: D53360609