Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'[skip ci] [RN][Android] Mark classes of packages reactperflogger as @Nullsafe #42855

Closed
wants to merge 5 commits into from

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Feb 4, 2024

Summary:
All these classes are NullSafe, let'''s mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Differential Revision: D53393136

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Feb 4, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393136

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393136

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393136

mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 4, 2024
…book#42855)

Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Differential Revision: D53393136
mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 4, 2024
…book#42855)

Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Differential Revision: D53393136
mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 4, 2024
…book#42855)

Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Differential Revision: D53393136
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393136

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393136

mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 5, 2024
Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Differential Revision: D53393136
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393136

2 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393136

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393136

@analysis-bot
Copy link

analysis-bot commented Feb 5, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,233,416 -5
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,600,225 +4
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: e4342f5
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393136

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393136

mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 5, 2024
…book#42855)

Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393136
mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 5, 2024
…book#42855)

Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393136
mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 5, 2024
…book#42855)

Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393136
mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 5, 2024
…book#42855)

Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393136
mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 6, 2024
Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393136
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393136

mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 6, 2024
…book#42855)

Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393136
…ook#42850)

Summary:

HybridData can not be null, fixing nullability in DefaultTurboModuleManagerDelegate

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393139
Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393140
Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393137
…acebook#42854)

Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393141
Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393136
mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 6, 2024
…book#42855)

Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393136
mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 6, 2024
…book#42855)

Summary:

All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D53393136
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53393136

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 9911dec.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants