Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot find module react-native-*/Libraries/Core/InitializeCore #42875

Closed
wants to merge 1 commit into from

Conversation

tido64
Copy link
Collaborator

@tido64 tido64 commented Feb 5, 2024

Summary:

@react-native/community-cli-plugin is unable to resolve out-of-tree platforms in monorepos because the package may not be hoisted to the same location. For example, if @react-native/community-cli-plugin was hoisted:

/~/node_modules/@react-native/community-cli-plugin/dist/utils

It may never find react-native-macos if it wasn't hoisted:

/~/packages/my-app/node_modules/react-native-macos

Changelog:

[GENERAL] [FIXED] - Fix @react-native/community-cli-plugin is unable to resolve out-of-tree platforms in monorepos

Test Plan:

Tested in an internal project.

@tido64 tido64 requested review from huntie, cortinico and kelset February 5, 2024 15:10
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Feb 5, 2024
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,233,375 +1
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,600,181 -15
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: fe69f71
Branch: main

@facebook-github-bot
Copy link
Contributor

@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@robhogan merged this pull request in e350859.

@tido64 tido64 deleted the tido/fix-cli-plugin-oot-platforms branch February 5, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants