Fix Reload behavior being different on Bridgeless #42917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53526369 |
Summary: If the app is not connected to Metro, the behavior of the refresh is different between bridgeless and bridge. This is because the `handleReloadJS` is implemented differently between the two support managers. I'm fixing it. Changelog: [Android] [Fixed] - Fix Reload behavior being different on Bridgeless Differential Revision: D53526369
cortinico
force-pushed
the
export-D53526369
branch
from
a978e8b to
1148f48
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53526369 |
Base commit: f0d1d92 |
|
This pull request has been merged in 85257a9. |
3 tasks
Kudo
added a commit
to expo/expo
that referenced
this pull request
Jun 7, 2024
# Why fix the empty screen after reloading on bridgeless android with dev-client. # How the relevant issue is facebook/react-native#44241 but facebook/react-native@524e3ee comes with breaking changes and would better to fix on 0.75. i would just address facebook/react-native#42917 on this pr for 0.74
Kudo
added a commit
to expo/expo
that referenced
this pull request
Jun 11, 2024
# Why fix the empty screen after reloading on bridgeless android with dev-client. # How the relevant issue is facebook/react-native#44241 but facebook/react-native@524e3ee comes with breaking changes and would better to fix on 0.75. i would just address facebook/react-native#42917 on this pr for 0.74 (cherry picked from commit e548e58)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
If the app is not connected to Metro, the behavior of the refresh is different between bridgeless and bridge. This is because the
handleReloadJSis implemented differently between the two support managers. I'm fixing it.Changelog:
[Android] [Fixed] - Fix Reload behavior being different on Bridgeless
Differential Revision: D53526369