Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][CI] Install CMake on Windows replying yes to the prompt #42926

Closed
wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

Summary:

CircleCI is failing because chocolatey started asking for user input in CI. This change should allow CI to proceed.

Changelog:

[Internal] - Fix CI on Windows

Test Plan:

CircleCI is green

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Feb 8, 2024
@cipolleschi cipolleschi force-pushed the cipolleschi/fix_build_hermes_windows branch from ae608d2 to 7b676c3 Compare February 8, 2024 16:33
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,233,606 -4
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,600,141 -5
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: eb61946
Branch: main

@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 527d193.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 8, 2024
@cortinico cortinico deleted the cipolleschi/fix_build_hermes_windows branch June 10, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants