Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][iOS] Fix flipper for Xcode 15.3 #43341

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Mar 6, 2024

Following #43335, we implemented the fix suggested here.

The rationale of applying this fix rather then releasing a new version of Flipper is because we will have to release Flipper 0.248.0, and the latest flipper version on Cocoapods is 0.233.0 (15 versions behind).

Plus, we have to backport the fix to 0.72 and 0.71 and bumping Flipper there would be a major pain and it might require more time and introduce other bugs we don't want.

Changelog

[iOS][Fixed] - Make 0.73 build with Xcode 15.3

Test Plan

Tested locally + CircleCI is green

@cipolleschi cipolleschi changed the base branch from main to 0.73-stable March 6, 2024 13:54
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

Fails
🚫

📋 Missing Changelog - Please add a Changelog to your PR description. See Changelog format

Warnings
⚠️ 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 228c2b0

@cipolleschi cipolleschi marked this pull request as ready for review March 6, 2024 13:58
@analysis-bot
Copy link

analysis-bot commented Mar 6, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,500,634 -9,503,721
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,754,914 -11,607,888
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 3ed0ff3
Branch: main

@cipolleschi cipolleschi force-pushed the cipolleschi/bump-flipper branch 2 times, most recently from ca5f9c9 to 05773c6 Compare March 6, 2024 15:30
@cipolleschi cipolleschi force-pushed the cipolleschi/bump-flipper branch from 05773c6 to 9d22a7f Compare March 6, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants