-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RN][iOS] Fix flipper for Xcode 15.3 #43341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
Mar 6, 2024
|
mptorz
reviewed
Mar 6, 2024
Base commit: 3ed0ff3 |
cipolleschi
force-pushed
the
cipolleschi/bump-flipper
branch
2 times, most recently
from
March 6, 2024 15:30
ca5f9c9
to
05773c6
Compare
cipolleschi
force-pushed
the
cipolleschi/bump-flipper
branch
from
March 6, 2024 15:31
05773c6
to
9d22a7f
Compare
hurali97
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
Pick Request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #43335, we implemented the fix suggested here.
The rationale of applying this fix rather then releasing a new version of Flipper is because we will have to release Flipper
0.248.0
, and the latest flipper version on Cocoapods is0.233.0
(15 versions behind).Plus, we have to backport the fix to 0.72 and 0.71 and bumping Flipper there would be a major pain and it might require more time and introduce other bugs we don't want.
Changelog
[iOS][Fixed] - Make 0.73 build with Xcode 15.3
Test Plan
Tested locally + CircleCI is green