fix(dev-middleware): create custom message handler for synthetic page #43559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
motiz88
requested changes
Mar 19, 2024
packages/dev-middleware/src/__tests__/InspectorProxyCustomMessageHandler-test.js
Outdated
Show resolved
Hide resolved
byCedric
force-pushed
the
@bycedric/dev-middleware/use-virtual-page-in-message-handlers
branch
from
b248a5a
to
d69180f
Compare
3 tasks
byCedric
added a commit
to expo/expo
that referenced
this pull request
Mar 19, 2024
# Why This is the implementation side of facebook/react-native#43291, and facebook/react-native#43310. ~~PR is back in draft state due to facebook/react-native#43559 Going to merge it as is, to fix CI. # How - Drop `InspectorProxy` and `Device` override classes - Rename `InspectorHandlers` to `MessageMiddleware` - ~~Temporarily polyfill required types until `@react-native/dev-middleware` is published with this new API~~ _We now use all types from this package, derived from the `CustomMessageHandlerConnection` and `CreateCustomMessageHandlerFn` types._ - ~~Drop the `VscodeDebuggerScriptParsed` middleware as that mutates the `Device` instance~~ _This was added to optimize the source map loading. It should still work without this handler. There is work going on from Meta's side to make source map loading follow web behavior more, but that's still in progress._ # Test Plan See updated tests, need to test this when `@react-native/dev-middleware` is updated. # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
byCedric
changed the title
byCedric
changed the title
huntie
approved these changes
Mar 20, 2024
|
@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
huntie
pushed a commit
that referenced
this pull request
Mar 21, 2024
…#43559) Summary: This is a follow-up bugfix for expo/expo#27425, related to: - #43291 - #43307 - #43310 - #43364 The middleware API works as intended and can run our extended CDP events. Unfortunately, this only applies to an actual `Page` from the device, not for the `React Native Experimental (Improved Chrome Reloads)` synthetic / virtual page. That's because the middleware instantiation gets aborted when the page can't be found in `this.#pages.get(pageId)`, which always returns `null` for this synthetic page. ## Changelog: [GENERAL] [FIXED] Create custom message handler for synthetic page Pull Request resolved: #43559 Test Plan: See added test case. Reviewed By: motiz88 Differential Revision: D55129412 Pulled By: huntie fbshipit-source-id: 9679d8fe68f3cb4104f4a042f93612b995baddc9
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a follow-up bugfix for expo/expo#27425, related to:
nativeNetworkInspectiontarget capabilty flag #43310userAgentquery parameter as fallback when header is unset #43364The middleware API works as intended and can run our extended CDP events. Unfortunately, this only applies to an actual
Pagefrom the device, not for theReact Native Experimental (Improved Chrome Reloads)synthetic / virtual page.That's because the middleware instantiation gets aborted when the page can't be found in
this.#pages.get(pageId), which always returnsnullfor this synthetic page.Changelog:
[GENERAL] [FIXED] Create custom message handler for synthetic page
Test Plan:
See added test case.