[Android] Add onUserLeaveHint support to ReactActivityDelegate #43488 #43567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds
onUserLeaveHint
support into theReactActivityDelegate
. It allows modules to receive an event every time user moves the app into the background. This is slightly different thanonPause
- it's called only when the user intentionally moves the app into the background, e.g. when receiving a callonPause
should be called butonUserLeaveHint
shouldn't.This feature is especially useful for libraries implementing features like Picture in Picture (PiP), where using
onUserLeaveHint
is the recommended way of auto-entering PiP for android < 12.This is a re-submission of #42741 and #43488 without problematic asserts, which were unnecessary (
onUserLeaveHint
is not critical to the lifecycle of the app), but were causing problems in some apps.Changelog:
[ANDROID] [ADDED] - Added
onUserLeaveHint
support intoReactActivityDelegate
Test Plan:
Tested in the
rn-tester
app - callbacks are correctly called on both old and new architecture.