-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose ReactDelegate for react-native-restart #43588
Closed
arushikesarwani94
wants to merge
1
commit into
facebook:main
from
arushikesarwani94:export-D55166962
Closed
Expose ReactDelegate for react-native-restart #43588
arushikesarwani94
wants to merge
1
commit into
facebook:main
from
arushikesarwani94:export-D55166962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Mar 21, 2024
This pull request was exported from Phabricator. Differential Revision: D55166962 |
Summary: Supported `reload()` in Bridgeless through ReactDelegate in facebook#43521 in order to unblock react-native-restart https://github.com/avishayil/react-native-restart/blob/134cabd5b3f355ffe551e5dd1be1dd46d870fe13/android/src/main/java/com/reactnativerestart/RestartModule.java#L54 which can access React Delegate through : ``` if(currentActivity instanceof ReactActivity) { ReactActivity reactActivity = (ReactActivity) currentActivity; ReactDelegate reactDelegate = reactActivity.getReactDelegate(); reactDelegate.reload() } ``` Changelog: [Android][Added] Expose ReactDelegate in ReactActivity Differential Revision: D55166962
arushikesarwani94
force-pushed
the
export-D55166962
branch
from
March 21, 2024 04:50
36477ae
to
7adc962
Compare
This pull request was exported from Phabricator. Differential Revision: D55166962 |
Base commit: 0267ca0 |
This pull request has been merged in 62ebe55. |
cortinico
pushed a commit
that referenced
this pull request
Mar 25, 2024
Summary: Pull Request resolved: #43588 Supported `reload()` in Bridgeless through ReactDelegate in #43521 in order to unblock react-native-restart https://github.com/avishayil/react-native-restart/blob/134cabd5b3f355ffe551e5dd1be1dd46d870fe13/android/src/main/java/com/reactnativerestart/RestartModule.java#L54 which can access React Delegate through : ``` if(currentActivity instanceof ReactActivity) { ReactActivity reactActivity = (ReactActivity) currentActivity; ReactDelegate reactDelegate = reactActivity.getReactDelegate(); reactDelegate.reload() } ``` Changelog: [Android][Added] Expose ReactDelegate in ReactActivity Reviewed By: cortinico Differential Revision: D55166962 fbshipit-source-id: 5d8dfd7ad61edbcb5233014800eb66a538842ca5
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Mar 25, 2024
Summary: facebook#43521 & facebook#43588 aimed to fix `react-native-restart`, however in release `handleReloadJS()` is a no-op in [DisabledDevSupportManager](https://github.com/facebook/react-native/blob/ac714b1c3300d3a169bdcfec05d556e18a7b83ff/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java#L139) which is why this should not work. Fixing it by relying on `ReactHostImpl.reload()` instead for Bridgeless. Differential Revision: D55342296
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Mar 25, 2024
Summary: facebook#43521 & facebook#43588 aimed to fix `react-native-restart`, however in release `handleReloadJS()` is a no-op in [DisabledDevSupportManager](https://github.com/facebook/react-native/blob/ac714b1c3300d3a169bdcfec05d556e18a7b83ff/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java#L139) which is why this should not work. Fixing it by relying on `ReactHostImpl.reload()` instead for Bridgeless. Differential Revision: D55342296
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Mar 26, 2024
Summary: facebook#43521 & facebook#43588 aimed to fix `react-native-restart`, however in release `handleReloadJS()` is a no-op in [DisabledDevSupportManager](https://github.com/facebook/react-native/blob/ac714b1c3300d3a169bdcfec05d556e18a7b83ff/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java#L139) which is why this should not work. Fixing it by relying on `ReactHostImpl.reload()` instead for Bridgeless. Differential Revision: D55342296
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Mar 26, 2024
Summary: facebook#43521 & facebook#43588 aimed to fix `react-native-restart`, however in release `handleReloadJS()` is a no-op in [DisabledDevSupportManager](https://github.com/facebook/react-native/blob/ac714b1c3300d3a169bdcfec05d556e18a7b83ff/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java#L139) which is why this should not work. Fixing it by relying on `ReactHostImpl.reload()` instead for Bridgeless. Differential Revision: D55342296
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Mar 26, 2024
Summary: facebook#43521 & facebook#43588 aimed to fix `react-native-restart`, however in release `handleReloadJS()` is a no-op in [DisabledDevSupportManager](https://github.com/facebook/react-native/blob/ac714b1c3300d3a169bdcfec05d556e18a7b83ff/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java#L139) which is why this should not work. Fixing it by relying on `ReactHostImpl.reload()` instead for Bridgeless. Adding implementation of `DisabledDevSupportManager.handleReloadJS()` won't work as it would mean introducing circular dependency `devsupport` -> `runtime` Reviewed By: cortinico Differential Revision: D55342296
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Mar 26, 2024
Summary: facebook#43521 & facebook#43588 aimed to fix `react-native-restart`, however in release `handleReloadJS()` is a no-op in [DisabledDevSupportManager](https://github.com/facebook/react-native/blob/ac714b1c3300d3a169bdcfec05d556e18a7b83ff/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java#L139) which is why this should not work. Fixing it by relying on `ReactHostImpl.reload()` instead for Bridgeless. Adding implementation of `DisabledDevSupportManager.handleReloadJS()` won't work as it would mean introducing circular dependency `devsupport` -> `runtime` Reviewed By: cortinico Differential Revision: D55342296
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Mar 26, 2024
Summary: Pull Request resolved: facebook#43645 facebook#43521 & facebook#43588 aimed to fix `react-native-restart`, however in release `handleReloadJS()` is a no-op in [DisabledDevSupportManager](https://github.com/facebook/react-native/blob/ac714b1c3300d3a169bdcfec05d556e18a7b83ff/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java#L139) which is why this should not work. Fixing it by relying on `ReactHostImpl.reload()` instead for Bridgeless. Differential Revision: https://internalfb.com/D55342296
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Mar 27, 2024
Summary: Pull Request resolved: facebook#43645 facebook#43521 & facebook#43588 aimed to fix `react-native-restart`, however in release `handleReloadJS()` is a no-op in [DisabledDevSupportManager](https://github.com/facebook/react-native/blob/ac714b1c3300d3a169bdcfec05d556e18a7b83ff/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java#L139) which is why this should not work. Fixing it by relying on `ReactHostImpl.reload()` instead for Bridgeless. Differential Revision: https://internalfb.com/D55342296
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
Summary: Pull Request resolved: #43645 #43521 & #43588 aimed to fix `react-native-restart`, however in release `handleReloadJS()` is a no-op in [DisabledDevSupportManager](https://github.com/facebook/react-native/blob/ac714b1c3300d3a169bdcfec05d556e18a7b83ff/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java#L139) which is why this should not work. Fixing it by relying on `ReactHostImpl.reload()` instead for Bridgeless. Adding implementation of `DisabledDevSupportManager.handleReloadJS()` won't work as it would mean introducing circular dependency `devsupport` -> `runtime` Reviewed By: cortinico Differential Revision: D55342296 fbshipit-source-id: ee6fba68586a2bdd1163522f75e6beb1b7736f6c
huntie
pushed a commit
that referenced
this pull request
Apr 2, 2024
Summary: Pull Request resolved: #43645 #43521 & #43588 aimed to fix `react-native-restart`, however in release `handleReloadJS()` is a no-op in [DisabledDevSupportManager](https://github.com/facebook/react-native/blob/ac714b1c3300d3a169bdcfec05d556e18a7b83ff/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java#L139) which is why this should not work. Fixing it by relying on `ReactHostImpl.reload()` instead for Bridgeless. Adding implementation of `DisabledDevSupportManager.handleReloadJS()` won't work as it would mean introducing circular dependency `devsupport` -> `runtime` Reviewed By: cortinico Differential Revision: D55342296 fbshipit-source-id: ee6fba68586a2bdd1163522f75e6beb1b7736f6c
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Supported
reload()
in Bridgeless through ReactDelegate in #43521 in order to unblock react-native-restarthttps://github.com/avishayil/react-native-restart/blob/134cabd5b3f355ffe551e5dd1be1dd46d870fe13/android/src/main/java/com/reactnativerestart/RestartModule.java#L54
which can access React Delegate through :
Changelog:
[Android][Added] Expose ReactDelegate in ReactActivity
Differential Revision: D55166962