-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow use of RCTRootViewFactory from Swift #43590
feat: allow use of RCTRootViewFactory from Swift #43590
Conversation
Base commit: 44d59ea |
Hey @cipolleschi could you take a look at this? 🙏 |
Changes looks good to me, but we had to fix a couple of things that conflicts with the RCTRootViewFactory. Can you rebase on top of |
42a68f1
to
3e17ce1
Compare
Hey @cipolleschi thanks for reviewing - rebased |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@cipolleschi merged this pull request in 5aea518. |
This pull request was successfully merged by @okwasniewski in 5aea518. When will my fix make it into a release? | How to file a pick request? |
Summary:
The goal of this PR is to allow the usage of
RCTRootViewFactory
from Swift. The issue withRCTTurboModuleManager.h
is that it uses C++ in its header file, which is not allowed in Swift, making this initializer unavailable.This PR allows users to just pass configuration + adds a nullable annotation to bundleURL.
Example usage:
Changelog:
[IOS] [FIXED] - Allow usage of
RCTRootViewFactory
from SwiftTest Plan:
CI Green, check usage of initializer without turbo module delegate